feat(promisify): use native promisify and remove es6-promisify (#165)

* (feat) use native promisify and remove es6-promisify

* (revert) undo promise array

* fix: reverted and removed package via npm uninstall

Author: rxmarbles

example/oracle/index.js

@@ -1,45 +1,45 @@
 const express = require('express')
 const http = require('http')
-var oracledb = require('oracledb');
+var oracledb = require('oracledb')
 const terminus = require('../../lib/terminus')
 const app = express()
 
 var config = {
-  user: process.env.NODE_ORACLEDB_USER || "scott",
-  password: process.env.NODE_ORACLEDB_PASSWORD || "tiger",
-  connectString: process.env.NODE_ORACLEDB_CONNECTIONSTRING || "localhost:1521/XE",
+  user: process.env.NODE_ORACLEDB_USER || 'scott',
+  password: process.env.NODE_ORACLEDB_PASSWORD || 'tiger',
+  connectString: process.env.NODE_ORACLEDB_CONNECTIONSTRING || 'localhost:1521/XE',
   poolMin: 1,
   poolMax: 10,
   poolIncrement: 1
 }
 
-async function dbConnect() {
-  await oracledb.createPool(config);
-  var conn = await oracledb.getConnection();
+async function dbConnect () {
+  await oracledb.createPool(config)
+  var conn = await oracledb.getConnection()
 }
 
 app.get('/dual', async (req, res) => {
-  var conn = await oracledb.getConnection();
+  var conn = await oracledb.getConnection()
   const result = await conn
-    .execute(`select JSON_OBJECT('id' value sys_guid()) from dual`)
-  res.json(result.rows[0]);
+    .execute('select JSON_OBJECT(\'id\' value sys_guid()) from dual')
+  res.json(result.rows[0])
 })
 
-async function onHealthCheck() {
-  var conn = await oracledb.getConnection();
+async function onHealthCheck () {
+  var conn = await oracledb.getConnection()
   console.log('pinging oracle db')
-  return conn.ping();
+  return conn.ping()
 }
 
-function onSignal() {
+function onSignal () {
   console.log('server is starting cleanup')
   oracledb.getPool().close().then(() => console.log('Oracle database connection closed'))
     .catch(err => console.error('error during disconnection', err.stack))
 }
 
-async function startServer() {
+async function startServer () {
   // get oracle connection
-  await dbConnect();
+  await dbConnect()
   console.log('Oracle database connection established')
 
   terminus.createTerminus(http.createServer(app), {
@@ -54,4 +54,4 @@ async function startServer() {
 }
 
 startServer()
-  .catch(err => console.error('connection error', err.stack))
+  .catch(err => console.error('connection error', err.stack))

lib/terminus.js

@@ -1,7 +1,7 @@
 'use strict'
 
 const stoppable = require('stoppable')
-const { promisify } = require('es6-promisify')
+const { promisify } = require('util')
 
 const SUCCESS_RESPONSE = JSON.stringify({
   status: 'ok'
@@ -15,9 +15,7 @@ function noopResolves () {
   return Promise.resolve()
 }
 
-async function sendSuccess (res, options) {
-  const { info, verbatim } = options
-
+async function sendSuccess (res, { info, verbatim }) {
   res.statusCode = 200
   res.setHeader('Content-Type', 'application/json')
   if (info) {

lib/terminus.spec.js

@@ -108,7 +108,7 @@ describe('Terminus', () => {
       let hasUnhandledRejection = false
 
       process.once('unhandledRejection', () => {
-        hasUnhandledRejection = true;
+        hasUnhandledRejection = true
       })
 
       server.on('request', () => {
@@ -121,7 +121,7 @@ describe('Terminus', () => {
             healthCheckRanTimes++
             return Promise.resolve()
           }
-        },
+        }
       })
       server.listen(8000)
 

package-lock.json

@@ -20,7 +20,6 @@
   "author": "",
   "license": "MIT",
   "dependencies": {
-    "es6-promisify": "^6.0.2",
     "stoppable": "^1.1.0"
   },
   "devDependencies": {