-
-
Notifications
You must be signed in to change notification settings - Fork 22.4k
Add CameraFeed support for Windows #105476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Remove movie writer and some other changes Seems like everything compiles Now everything compiles
@0xafbf Also, I'd like to request the addition of the The signal implementation seems to be missing in the macOS version, so I've submitted a PR to address this. |
If you are using someone else's work in your PR you need to give then co-author status, at least if you copy any large portions of your code from them |
This comment was marked as off-topic.
This comment was marked as off-topic.
Please do not bump PRs without adding additional information |
@0xafbf diff --git a/modules/camera/camera_win.cpp b/modules/camera/camera_win.cpp
--- a/modules/camera/camera_win.cpp (revision e777a599ed82278742eb4f8471058cf967e11b8a)
+++ b/modules/camera/camera_win.cpp (date 1747086735202)
@@ -43,9 +43,9 @@
#ifndef defer
template<typename Fn>
struct _deferClass {
- Fn fn;
- _deferClass(Fn&& fn): fn(fn){}
- ~_deferClass() { fn(); }
+ Fn _fn;
+ _deferClass(Fn&& fn): _fn(fn){}
+ ~_deferClass() { _fn(); }
};
#define DEFER_CONCAT_INTERNAL(a, b) a##b
|
I started this PR based on this one: #98416
I cleaned up the structures, where original PR presented every format (width+height+framerate+encoding) as a different feed.
With this PR we create a CameraFeed per device, and each feed exposes the different formats.
Still WIP and missing some final cleanup.