From 31d407da7cafd0cabba027a795393016eae81e82 Mon Sep 17 00:00:00 2001 From: Aaron Franke Date: Wed, 12 Aug 2026 17:29:13 -0700 Subject: [PATCH] [4.4] Use explicit public access modifier in C# code --- .../GodotTools.IdeMessaging/IHandshake.cs | 4 ++-- .../GodotTools.IdeMessaging/ILogger.cs | 10 +++++----- .../IMessageHandler.cs | 2 +- .../GodotTools.OpenVisualStudio/Program.cs | 6 +++--- .../GodotSharp/Core/Interfaces/IAwaitable.cs | 12 +++++++++-- .../GodotSharp/Core/Interfaces/IAwaiter.cs | 20 +++++++++++++++---- .../Core/Interfaces/ISerializationListener.cs | 4 ++-- 7 files changed, 39 insertions(+), 19 deletions(-) diff --git a/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/IHandshake.cs b/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/IHandshake.cs index 8ec60876ccb6..66ba50322fcd 100644 --- a/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/IHandshake.cs +++ b/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/IHandshake.cs @@ -4,7 +4,7 @@ namespace GodotTools.IdeMessaging { public interface IHandshake { - string GetHandshakeLine(string identity); - bool IsValidPeerHandshake(string handshake, [NotNullWhen(true)] out string? identity, ILogger logger); + public string GetHandshakeLine(string identity); + public bool IsValidPeerHandshake(string handshake, [NotNullWhen(true)] out string? identity, ILogger logger); } } diff --git a/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/ILogger.cs b/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/ILogger.cs index d2855f93a136..2df480cc191f 100644 --- a/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/ILogger.cs +++ b/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/ILogger.cs @@ -4,10 +4,10 @@ namespace GodotTools.IdeMessaging { public interface ILogger { - void LogDebug(string message); - void LogInfo(string message); - void LogWarning(string message); - void LogError(string message); - void LogError(string message, Exception e); + public void LogDebug(string message); + public void LogInfo(string message); + public void LogWarning(string message); + public void LogError(string message); + public void LogError(string message, Exception e); } } diff --git a/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/IMessageHandler.cs b/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/IMessageHandler.cs index 9622fcc96db4..08abf9a51e9a 100644 --- a/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/IMessageHandler.cs +++ b/modules/mono/editor/GodotTools/GodotTools.IdeMessaging/IMessageHandler.cs @@ -4,6 +4,6 @@ namespace GodotTools.IdeMessaging { public interface IMessageHandler { - Task HandleRequest(Peer peer, string id, MessageContent content, ILogger logger); + public Task HandleRequest(Peer peer, string id, MessageContent content, ILogger logger); } } diff --git a/modules/mono/editor/GodotTools/GodotTools.OpenVisualStudio/Program.cs b/modules/mono/editor/GodotTools/GodotTools.OpenVisualStudio/Program.cs index 5bf07f626bac..45f4eded8503 100644 --- a/modules/mono/editor/GodotTools/GodotTools.OpenVisualStudio/Program.cs +++ b/modules/mono/editor/GodotTools/GodotTools.OpenVisualStudio/Program.cs @@ -281,13 +281,13 @@ int IOleMessageFilter.MessagePending(IntPtr hTaskCallee, int dwTickCount, int dw private interface IOleMessageFilter { [PreserveSig] - int HandleInComingCall(int dwCallType, IntPtr hTaskCaller, int dwTickCount, IntPtr lpInterfaceInfo); + public int HandleInComingCall(int dwCallType, IntPtr hTaskCaller, int dwTickCount, IntPtr lpInterfaceInfo); [PreserveSig] - int RetryRejectedCall(IntPtr hTaskCallee, int dwTickCount, int dwRejectType); + public int RetryRejectedCall(IntPtr hTaskCallee, int dwTickCount, int dwRejectType); [PreserveSig] - int MessagePending(IntPtr hTaskCallee, int dwTickCount, int dwPendingType); + public int MessagePending(IntPtr hTaskCallee, int dwTickCount, int dwPendingType); } #endregion diff --git a/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/IAwaitable.cs b/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/IAwaitable.cs index e747e03c1e02..fc13176f5905 100644 --- a/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/IAwaitable.cs +++ b/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/IAwaitable.cs @@ -5,7 +5,11 @@ namespace Godot /// public interface IAwaitable { - IAwaiter GetAwaiter(); + /// + /// Gets an Awaiter for this . + /// + /// An Awaiter. + public IAwaiter GetAwaiter(); } /// @@ -14,6 +18,10 @@ public interface IAwaitable /// A reference to the result to be passed out. public interface IAwaitable { - IAwaiter GetAwaiter(); + /// + /// Gets an Awaiter for this . + /// + /// An Awaiter. + public IAwaiter GetAwaiter(); } } diff --git a/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/IAwaiter.cs b/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/IAwaiter.cs index dec225eb2919..7394b9f3520d 100644 --- a/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/IAwaiter.cs +++ b/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/IAwaiter.cs @@ -7,9 +7,15 @@ namespace Godot /// public interface IAwaiter : INotifyCompletion { - bool IsCompleted { get; } + /// + /// The completion status of this . + /// + public bool IsCompleted { get; } - void GetResult(); + /// + /// Gets the result of completion for this . + /// + public void GetResult(); } /// @@ -18,8 +24,14 @@ public interface IAwaiter : INotifyCompletion /// A reference to the result to be passed out. public interface IAwaiter : INotifyCompletion { - bool IsCompleted { get; } + /// + /// The completion status of this . + /// + public bool IsCompleted { get; } - TResult GetResult(); + /// + /// Gets the result of completion for this . + /// + public TResult GetResult(); } } diff --git a/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/ISerializationListener.cs b/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/ISerializationListener.cs index 3288705dab82..6cb6de86ec91 100644 --- a/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/ISerializationListener.cs +++ b/modules/mono/glue/GodotSharp/GodotSharp/Core/Interfaces/ISerializationListener.cs @@ -10,12 +10,12 @@ public interface ISerializationListener /// Executed before serializing this instance's state when reloading assemblies. /// Clear any data that should not be serialized. /// - void OnBeforeSerialize(); + public void OnBeforeSerialize(); /// /// Executed after deserializing this instance's state after reloading assemblies. /// Restore any state that has been lost. /// - void OnAfterDeserialize(); + public void OnAfterDeserialize(); } }