Skip to content

Commit 33325c6

Browse files
committed
minor changes were made
1 parent f5ac8de commit 33325c6

File tree

2 files changed

+17
-3
lines changed

2 files changed

+17
-3
lines changed

email-verification/application/verification_service.go

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,14 @@ func NewVerificationService(
2929
}
3030

3131
func (s *VerificationService) SendVerification(email string) error {
32+
if email == "" {
33+
return fmt.Errorf("email cannot be empty")
34+
}
35+
36+
if _, err := s.repo.Get(email); err == nil {
37+
return fmt.Errorf("verification already pending")
38+
}
39+
3240
code, err := s.codeGen.Generate()
3341
if err != nil {
3442
return err
@@ -47,6 +55,10 @@ func (s *VerificationService) SendVerification(email string) error {
4755
}
4856

4957
func (s *VerificationService) VerifyCode(email, code string) error {
58+
if email == "" || code == "" {
59+
return fmt.Errorf("email and code cannot be empty")
60+
}
61+
5062
verification, err := s.repo.Get(email)
5163
if err != nil {
5264
return err
@@ -58,7 +70,9 @@ func (s *VerificationService) VerifyCode(email, code string) error {
5870
}
5971

6072
if time.Now().After(verification.Exp) {
61-
s.repo.Delete(email)
73+
if err := s.repo.Delete(email); err != nil {
74+
return fmt.Errorf("failed to delete expired code: %w", err)
75+
}
6276
return fmt.Errorf("code expired")
6377
}
6478

email-verification/config/config.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ func GetConfig() *Config {
1616
return &Config{
1717
SMTPHost: "smtp.gmail.com",
1818
SMTPPort: 587,
19-
SMTPUser: "your-email@gmail.com",
20-
SMTPPassword: "your-app-password",
19+
SMTPUser: "tahasfhga@gmail.com",
20+
SMTPPassword: "bakkcmkakpfxwuef",
2121
CodeExpiration: time.Minute * 1,
2222
}
2323
}

0 commit comments

Comments
 (0)