-
-
Notifications
You must be signed in to change notification settings - Fork 492
docs: update README to include public folder requirement for Vercel #3844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ayclqt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request improves the clarity and security guidance within the Vercel deployment documentation. It introduces a crucial detail about the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the README.md for the Vercel example to include a crucial requirement for a public folder. It correctly warns users that without this folder, Vercel might expose all project files, including source code. My feedback includes a suggestion to make the warning message even more explicit about the security risk to prevent any potential misinterpretation. Overall, this is a valuable documentation improvement.
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughUpdated Vercel README to require a Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📓 Common learnings🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
vercel/README.md (2)
26-30: Add public folder to Project Structure.The Project Structure section should include the newly required
publicfolder for completeness and clarity. Once you confirm the folder exists, update this section:## Project Structure - `api/index.go`: The main entry point for the serverless function. - `vercel.json`: Configuration file for Vercel. - `go.mod`: The Go module file. +- `public/`: Static files served by Vercel.
32-43: Add guidance on creating the public folder in Setup.Users should understand how to create and populate the
publicfolder as part of the setup. Consider adding a step:## Setup 1. Clone the repository: ```bash git clone https://github.com/gofiber/recipes.git cd recipes/vercel ``` +2. Create the public folder with static files: + ```bash + mkdir -p public + echo "Hello from Vercel!" > public/index.html + ``` + -2. Install the dependencies: +3. Install the dependencies:
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
vercel/README.md(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: ReneWerner87
Repo: gofiber/recipes PR: 0
File: :0-0
Timestamp: 2024-11-26T20:05:15.793Z
Learning: For future contributions to the `gofiber/recipes` repository, ensure that the tasks outlined in `.github/CONTRIBUTING.md` are incorporated, including creating a new directory without a "fiber" prefix, adding a `README.md` with Docusaurus metadata, and updating the overview by running `make generate`.
🔇 Additional comments (1)
vercel/README.md (1)
22-24: Remove references to the public folder requirement—this content does not exist in the file.The review comment references lines 22-24 containing a public folder requirement and caution block, but the current vercel/README.md does not include this content. The Requirements section (lines 17-21) lists only Go, Git, and Vercel CLI. The Project Structure (lines 23-27) lists only api/index.go, vercel.json, and go.mod. The public folder does not exist in the vercel directory.
If adding a public folder requirement to this documentation is intended, that change should be proposed separately in the PR. However, as currently written, this review comment addresses non-existent code.
Likely an incorrect or invalid review comment.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Congrats on merging your first pull request! 🎉 We here at Fiber are proud of you! |
Added public folder to Vercel recipes and warning if users don't have it in README.MD
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.