fix: CI

Author: Andrei-hub11

godump_integration_test.go

@@ -29,13 +29,15 @@ func main() {
 		t.Fatalf("failed to create temp file: %v", err)
 	}
 
-	if _, err := tempFile.WriteString(sourceCode); err != nil {
+	_, err = tempFile.WriteString(sourceCode)
+	if err != nil {
 		t.Fatalf("failed to write temp file: %v", err)
 	}
 	tempFile.Close()
 
 	// Run the program using `go run`. By capturing the output, we ensure
 	// that the program's stdout is not a TTY.
+	//nolint:gosec // tempFile.Name() is a controlled temporary file created by this test
 	cmd := exec.Command("go", "run", tempFile.Name())
 	output, err := cmd.CombinedOutput()
 	if err != nil {
@@ -68,13 +70,15 @@ func main() {
 		t.Fatalf("failed to create temp file: %v", err)
 	}
 
-	if _, err := tempFile.WriteString(sourceCode); err != nil {
+	_, err = tempFile.WriteString(sourceCode)
+	if err != nil {
 		t.Fatalf("failed to write temp file: %v", err)
 	}
 	tempFile.Close()
 
 	// Run the program using `go run`. By capturing the output, we ensure
 	// that the program's stdout is not a TTY.
+	//nolint:gosec // tempFile.Name() is a controlled temporary file created by this test
 	cmd := exec.Command("go", "run", tempFile.Name())
 
 	cmd.Env = append(os.Environ(), "FORCE_COLOR=1")

terminal_unix.go

@@ -7,11 +7,13 @@ import (
 	"testing"
 )
 
+var isTestEnv = testing.Testing
+
 // isTerminal checks if the given file is a terminal.
 // Uses ModeCharDevice on Unix-like systems.
 // In test environments, it returns true unless explicitly overridden by environment variables.
 func isTerminal(f *os.File) bool {
-	if isTestEnvironment() {
+	if isTestEnv() {
 		return true
 	}
 
@@ -20,9 +22,4 @@ func isTerminal(f *os.File) bool {
 		return false
 	}
 	return (fileInfo.Mode() & os.ModeCharDevice) != 0
-}
-
-// isTestEnvironment checks if the code is running in a test environment
-func isTestEnvironment() bool {
-	return testing.Testing()
-} 
+}

terminal_unix_test.go

@@ -0,0 +1,41 @@
+package godump
+
+import (
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestIsTerminal_Unix(t *testing.T) {
+	// Mock isTestEnv to bypass the test environment check
+	originalIsTestEnv := isTestEnv
+	isTestEnv = func() bool { return false }
+	defer func() { isTestEnv = originalIsTestEnv }()
+
+	t.Run("should return false for a regular file", func(t *testing.T) {
+		tmpFile, err := os.CreateTemp("", "test-is-terminal")
+		assert.NoError(t, err)
+		defer os.Remove(tmpFile.Name())
+		defer tmpFile.Close()
+
+		assert.False(t, isTerminal(tmpFile))
+	})
+
+	t.Run("should return false when stat fails", func(t *testing.T) {
+		tmpFile, err := os.CreateTemp("", "test-stat-fails")
+		assert.NoError(t, err)
+		tmpFile.Close()
+		os.Remove(tmpFile.Name())
+
+		assert.False(t, isTerminal(tmpFile))
+	})
+
+	t.Run("should return true when in test environment", func(t *testing.T) {
+		isTestEnv = func() bool { return true }
+		defer func() {
+			isTestEnv = originalIsTestEnv
+		}()
+		assert.True(t, isTerminal(os.Stdout))
+	})
+} 

terminal_windows.go

@@ -8,11 +8,13 @@ import (
 	"testing"
 )
 
+var isTestEnv = testing.Testing
+
 // isTerminal checks if the given file is a terminal.
 // Uses GetConsoleMode on Windows.
 // In test environments, it returns true unless explicitly overridden by environment variables.
 func isTerminal(f *os.File) bool {
-	if isTestEnvironment() {
+	if isTestEnv() {
 		return true
 	}
 
@@ -21,9 +23,4 @@ func isTerminal(f *os.File) bool {
 	// Fails for redirected/piped output
 	err := syscall.GetConsoleMode(syscall.Handle(f.Fd()), &mode)
 	return err == nil
-}
-
-// isTestEnvironment checks if the code is running in a test environment
-func isTestEnvironment() bool {
-	return testing.Testing()
-} 
+}

terminal_windows_test.go

@@ -0,0 +1,34 @@
+//go:build windows
+
+package godump
+
+import (
+	"os"
+	"testing"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func TestIsTerminal_Windows(t *testing.T) {
+	// Mock isTestEnv to bypass the test environment check
+	originalIsTestEnv := isTestEnv
+	isTestEnv = func() bool { return false }
+	defer func() { isTestEnv = originalIsTestEnv }()
+
+	t.Run("should return false for a regular file", func(t *testing.T) {
+		tmpFile, err := os.CreateTemp("", "test-is-terminal-windows")
+		assert.NoError(t, err)
+		defer os.Remove(tmpFile.Name())
+		defer tmpFile.Close()
+
+		// On Windows, GetConsoleMode should fail for a regular file, so isTerminal returns false.
+		assert.False(t, isTerminal(tmpFile))
+	})
+
+	t.Run("should return true when in test environment", func(t *testing.T) {
+		isTestEnv = func() bool { return true }
+		defer func() { isTestEnv = originalIsTestEnv }()
+		
+		assert.True(t, isTerminal(os.Stdout))
+	})
+}