Improve test, only call asStringer once

Author: bombsimon

godump.go

@@ -484,11 +484,7 @@ func (d *Dumper) printValue(w io.Writer, v reflect.Value, indent int, visited ma
 			}
 			indentPrint(w, indent+1, d.colorize(colorYellow, symbol)+field.Name)
 			fmt.Fprint(w, "	=> ")
-			if s := d.asStringer(fieldVal); s != "" {
-				fmt.Fprint(w, s)
-			} else {
-				d.printValue(w, fieldVal, indent+1, visited)
-			}
+			d.printValue(w, fieldVal, indent+1, visited)
 			fmt.Fprintln(w)
 		}
 		indentPrint(w, indent, "")

godump_test.go

@@ -1051,11 +1051,11 @@ func TestDumpJSON(t *testing.T) {
 func TestDisableStringer(t *testing.T) {
 	data := hidden{secret: "not so secret"}
 
-	d := NewDumper(WithDisableStringer(true))
+	d := newDumperT(t, WithDisableStringer(true))
 	v := d.DumpStr(data)
-	require.Contains(t, v, "not so secret")
+	require.Contains(t, v, `-secret => "not so secret"`)
 
-	d = NewDumper()
+	d = newDumperT(t)
 	v = d.DumpStr(data)
-	assert.Contains(t, v, "👻 hidden stringer")
+	assert.Contains(t, v, `-secret => 👻 hidden stringer`)
 }