feat: add gopls modernize integration via Makefile and GitHub Actions (#3)

Co-authored-by: Brandon Young <[email protected]>

Author: brandonyoungdev

.github/workflows/test.yml

@@ -17,10 +17,13 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: '1.23'
+          go-version: "1.23"
 
       - name: Install dependencies
         run: go mod tidy
 
+      - name: Check code modernization
+        run: make modernize-check
+
       - name: Run tests
         run: go test ./... -v

Makefile

@@ -0,0 +1,13 @@
+.PHONY: modernize modernize-fix modernize-check
+
+MODERNIZE_CMD = go run golang.org/x/tools/gopls/internal/analysis/modernize/cmd/[email protected]
+
+modernize: modernize-fix
+
+modernize-fix:
+	@echo "Running gopls modernize with -fix..."
+	$(MODERNIZE_CMD) -test -fix ./...
+
+modernize-check:
+	@echo "Checking if code needs modernization..."
+	$(MODERNIZE_CMD) -test ./...

godump.go

@@ -224,7 +224,7 @@ func printValue(tw *tabwriter.Writer, v reflect.Value, indent int, visited map[u
 
 		fmt.Fprintf(tw, "%s ", colorize(colorGray, "#"+t.String()))
 		fmt.Fprintln(tw)
-		for i := 0; i < v.NumField(); i++ {
+		for i := range v.NumField() {
 			field := t.Field(i)
 			fieldVal := v.Field(i)
 			symbol := "+"
@@ -260,7 +260,7 @@ func printValue(tw *tabwriter.Writer, v reflect.Value, indent int, visited map[u
 		fmt.Fprint(tw, "}")
 	case reflect.Slice, reflect.Array:
 		fmt.Fprintln(tw, "[")
-		for i := 0; i < v.Len(); i++ {
+		for i := range v.Len() {
 			if i >= maxItems {
 				indentPrint(tw, indent+1, colorize(colorGray, "... (truncated)\n"))
 				break

godump_test.go

@@ -65,7 +65,7 @@ func TestMaxDepth(t *testing.T) {
 	}
 	n := &Node{}
 	curr := n
-	for i := 0; i < 20; i++ {
+	for range 20 {
 		curr.Child = &Node{}
 		curr = curr.Child
 	}
@@ -234,7 +234,7 @@ func TestPrimitiveTypes(t *testing.T) {
 		uintptr(5),
 		float32(1.5),
 		[2]int{6, 7},
-		interface{}(42),
+		any(42),
 	))
 
 	assert.Contains(t, out, "1")        // int8
@@ -310,7 +310,7 @@ func TestMaxDepthTruncation(t *testing.T) {
 	}
 	root := &Node{}
 	curr := root
-	for i := 0; i < 20; i++ {
+	for range 20 {
 		curr.Next = &Node{}
 		curr = curr.Next
 	}
@@ -332,15 +332,15 @@ func TestDetectColorEnvVars(t *testing.T) {
 
 func TestMapTruncation(t *testing.T) {
 	largeMap := map[int]int{}
-	for i := 0; i < 200; i++ {
+	for i := range 200 {
 		largeMap[i] = i
 	}
 	out := stripANSI(DumpStr(largeMap))
 	assert.Contains(t, out, "... (truncated)")
 }
 
 func TestNilInterfaceTypePrint(t *testing.T) {
-	var x interface{} = (*int)(nil)
+	var x any = (*int)(nil)
 	out := stripANSI(DumpStr(x))
 	assert.Contains(t, out, "(nil)")
 }