fix: restore local loader artifact safety gate

Author: cmilesio

internal/loader/artifact_cache.go

@@ -153,13 +153,9 @@ func isProviderSetTypeForLoader(t types.Type) bool {
 	if obj == nil || obj.Pkg() == nil {
 		return false
 	}
-	return isWireImportPath(obj.Pkg().Path()) && obj.Name() == "ProviderSet"
-}
-
-func isWireImportPath(path string) bool {
-	switch path {
+	switch obj.Pkg().Path() {
 	case "github.com/goforj/wire", "github.com/google/wire":
-		return true
+		return obj.Name() == "ProviderSet"
 	default:
 		return false
 	}

internal/loader/custom.go

@@ -546,18 +546,6 @@ func (l *customTypedGraphLoader) localSemanticArtifactSupported(meta *packageMet
 	return art.Supported
 }
 
-func localPackageNeedsSemanticArtifacts(meta *packageMeta) bool {
-	if meta == nil {
-		return false
-	}
-	for _, path := range meta.Imports {
-		if isWireImportPath(path) {
-			return true
-		}
-	}
-	return false
-}
-
 func (l *customTypedGraphLoader) artifactPolicy(meta *packageMeta, isTarget, isLocal bool) artifactPolicy {
 	if !loaderArtifactEnabled(l.env) || isTarget {
 		return artifactPolicy{}
@@ -567,10 +555,6 @@ func (l *customTypedGraphLoader) artifactPolicy(meta *packageMeta, isTarget, isL
 		policy.read = true
 		return policy
 	}
-	if !localPackageNeedsSemanticArtifacts(meta) {
-		policy.read = true
-		return policy
-	}
 	policy.read = l.localSemanticArtifactSupported(meta)
 	return policy
 }

internal/loader/loader_test.go

@@ -2386,34 +2386,6 @@ func TestLoaderArtifactKeyExternalWithoutExportChangesWhenSourceChanges(t *testi
 	}
 }
 
-func TestArtifactPolicyLocalReadOnlyNeedsSemanticForWirePackages(t *testing.T) {
-	t.Parallel()
-
-	loader := &customTypedGraphLoader{
-		env:             []string{"WIRE_LOADER_ARTIFACTS=1"},
-		localSemanticOK: map[string]bool{"example.com/app": false},
-	}
-
-	nonWireMeta := &packageMeta{
-		ImportPath: "example.com/app",
-		Imports:    []string{"fmt", "example.com/dep"},
-	}
-	wireMeta := &packageMeta{
-		ImportPath: "example.com/app",
-		Imports:    []string{"github.com/goforj/wire"},
-	}
-
-	if got := loader.artifactPolicy(nonWireMeta, false, true); !got.read || !got.write {
-		t.Fatalf("artifactPolicy(non-wire local) = %+v, want read+write", got)
-	}
-	if got := loader.artifactPolicy(wireMeta, false, true); got.read || !got.write {
-		t.Fatalf("artifactPolicy(wire local without semantic support) = %+v, want write-only", got)
-	}
-	if got := loader.artifactPolicy(wireMeta, false, false); !got.read || !got.write {
-		t.Fatalf("artifactPolicy(wire external) = %+v, want read+write", got)
-	}
-}
-
 func TestRunGoListIncludesExportDataForReplacedModule(t *testing.T) {
 	root := t.TempDir()
 	depRoot := filepath.Join(root, "depmod")