consider enabling usetesting linter in golangci-lint

[ccoVeille]

https://golangci-lint.run/usage/linters/#usetesting

https://github.com/ldez/usetesting

Now you are using Go 1.24, we can activate it easily.

257 errors about the usage of t.Context
2 about t.Setenv
1 about t.TempDir

[Yadavanurag13]

@ccoVeille
@vikash I would like to pick this issue.

[ccoVeille]

I'm fine with it. You can take it.

For records, using golangci-lint run --enable-only usetesting locally will report the issues.

You can try golangci-lint run --fix --enable-only usetesting that might fix some of these issues reported

Note

I would like to keep the scope of this PR limited, so please do not try to migrate golangci-lint v2 in this issue
If you want to do it, then start by migrating to v2 by looking at #1645

• Migrate to golangci-lint v2 #1645

[ccoVeille]

@vikash @Umang01-hash @aryanmehrotra could you assign the issue to @Yadavanurag13

Thanks

[Yadavanurag13]

@ccoVeille So If I pick #1645 it will close this too? I'm thinking to migrate linter to v2? wdyt

[ccoVeille]

It can be done separately.

You can choose to work on the v2 migration too.

But then I would ask you to keep the PR separated. As the number of changes would be too large to review them.

But if you feel confident to migrate to v2, you can try.

But then you will still have to enable usetesting linter for this issue.

Migrating to v2 won't enable usetesting by magic, nor fix the issues this linter might report