Merge pull request #1986 from gofractally/no-doc-crtp-service

psibase::Service doesn't use CRTP

Author: swatanabe

doc/src/development/services/cpp-service/reference/services-events.md

@@ -4,32 +4,14 @@
 
 To define a service:
 
-- Make a struct or class. It may optionally publicly inherit from [psibase::Service] to gain the [psibase::Service::emit] and [psibase::Service::events] convenience methods.
+- Make a struct or class. It may optionally publicly inherit from [psibase::Service] to gain several convenience methods.
 - Define or declare the set of methods
 - Reflect the methods using `PSIO_REFLECT`. Only reflected methods become actions; these are available for transactions and for other services to call using [psibase::Actor] or [psibase::call].
 
-### Example without convenience base class:
-
-```c++
-struct MyService
-{
-   // The account this service is normally installed on. This definition
-   // is optional.
-   static constexpr auto service = psibase::AccountNumber("myservice");
-
-   void        doSomething(std::string_view str);
-   std::string somethingElse(uint32_t x, psibase::AccountNumber y);
-};
-
-PSIO_REFLECT(MyService,
-             method(doSomething, str),
-             method(somethingElse, x, y))
-```
-
 ### Example with convenience base class:
 
 ```c++
-struct MyService: psibase::Service<MyService>
+struct MyService: psibase::Service
 {
    // The account this service is normally installed on. This definition
    // is optional.
@@ -71,7 +53,7 @@ To define events for a service, declare the event functions as below, then refle
 After you have defined your events, use [psibase::Service::emit] to emit them and [psibase::Service::events] to read them.
 
 ```c++
-struct MyService: psibase::Service<MyService> {
+struct MyService: psibase::Service {
    struct Events {
       // Events which live a long time
       struct History {

libraries/psibase/common/include/psibase/Actor.hpp

@@ -380,7 +380,7 @@ namespace psibase
    /// For example, if `SomeService` has this set of methods:
    ///
    /// ```c++
-   /// struct SomeService : psibase::Service<SomeService>
+   /// struct SomeService : psibase::Service
    /// {
    ///    void        doSomething(std::string_view str);
    ///    std::string doAnother(uint32_t x, psibase::AccountNumber y);

libraries/psibase/common/include/psibase/serveGraphQL.hpp

@@ -280,7 +280,7 @@ namespace psibase
    /// };
    /// PSIO_REFLECT(Query, method(rowsByPrimary), method(rowsBySecondary))
    ///
-   /// struct ExampleService : psibase::Service<ExampleService>
+   /// struct ExampleService : psibase::Service
    /// {
    ///    std::optional<psibase::HttpReply> serveSys(psibase::HttpRequest request)
    ///    {