feat(cmd/gendao): add wildcard pattern support for tables configuration #4632
+707
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add wildcard pattern support (* and ?) for tables configuration - Fix tablesEx wildcard to use exact match (^$) for consistency - Add warning when exact table name does not exist - Add unit tests and integration tests for MySQL and PostgreSQL Changes: - tables: "user_*" now matches all tables starting with "user_" - tables: "*" matches all tables - tablesEx: "user_*" now uses exact match instead of partial match - Non-existent exact table names are skipped with warning Closes gogf#4629
…I table pollution The test was using Tables: "*" which matches all tables in the database, including tables from other tests. Changed to use specific patterns to match only our test tables.
Contributor
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
*and?) fortablesconfigurationtablesExwildcard to use exact match (^$) for consistencyChanges
tables: "user_*"tables: "*"tablesEx: "user_*"Features
*matches any characters (e.g.,user_*matchesuser_info,user_log)?matches single character (e.g.,user_???matchesuser_logbut notuser_info)tables: "user_*,config")Test plan
containsWildcard,patternToRegex,filterTablesByPatterns(11 cases)Closes #4629