You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: proposals/new/versatile-replication-filters.md
+120
Original file line number
Diff line number
Diff line change
@@ -121,3 +121,123 @@ src/pkg/reg/util
121
121
├── util.go
122
122
└── util_test.go
123
123
```
124
+
125
+
126
+
---
127
+
128
+
# Proposal Updates as per discussions
129
+
130
+
Proposal updates as per discussion with [Vadim Bauer](https://twitter.com/vad1mo)
131
+
132
+
Approach 2 specified in the proposal on taking regular expression from users is favored more.
133
+
134
+
Various approaches to get this done that we discussed are as follows:
135
+
136
+
137
+
138
+
1.**Add a new input field for regex:**
139
+
140
+
An additional input field to take user input can be added as follows along with the existing ones. Users can input an expression that will be matched against the artifacts' name, label, and tag.
* No migration is needed. Existing rules will continue working.
148
+
149
+
* Users can switch to regex-based filtering at their convenience.
150
+
151
+
152
+
**Cons:**
153
+
154
+
* Logical and development complexity as novice users might need/try to combine regex and glob-based filtering which is complex to understand and develop.
155
+
156
+
* The development effort needed is significant. UI portal, databases, API handlers, and filtering logic are some of the components that need to be modified which is time-consuming, complex, and has the potential of breaking and causing bugs.
157
+
158
+
159
+
160
+
2.**Accept regular expressions in existing input fields and distinguish between glob pattern and regex using some specifier like**`/<regex>/`**as follows**
0 commit comments