test cmds and make changes

test create cmd

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

test all cmds

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

lint fix

Signed-off-by: Rizul Gupta <mail2rizul@gmail.com>

Author: rizul2108

cmd/harbor/root/webhook/create.go

@@ -18,6 +18,7 @@ import (
 
 	"github.com/goharbor/harbor-cli/pkg/api"
 	"github.com/goharbor/harbor-cli/pkg/prompt"
+	"github.com/goharbor/harbor-cli/pkg/utils"
 	"github.com/goharbor/harbor-cli/pkg/views/webhook/create"
 	"github.com/spf13/cobra"
 )
@@ -68,6 +69,10 @@ or leave them out and be guided through an interactive prompt to input each fiel
 				opts.NotifyType != "" &&
 				len(opts.EventType) != 0 &&
 				opts.EndpointURL != "" {
+				err = utils.ValidateURL(opts.EndpointURL)
+				if err != nil {
+					return err
+				}
 				err = api.CreateWebhook(&opts)
 			} else {
 				err = createWebhookView(createView)
@@ -84,7 +89,7 @@ or leave them out and be guided through an interactive prompt to input each fiel
 	flags.StringVarP(&opts.ProjectName, "project", "", "", "Project Name")
 	flags.StringVarP(&opts.Description, "description", "", "", "Webhook Description")
 	flags.StringVarP(&opts.NotifyType, "notify-type", "", "", "Notify Type (http, slack)")
-	flags.StringArrayVarP(&opts.EventType, "event-type", "", []string{}, "Event Types (comma separated)")
+	flags.StringSliceVarP(&opts.EventType, "event-type", "", []string{}, "Event Types (comma separated)")
 	flags.StringVarP(&opts.EndpointURL, "endpoint-url", "", "", "Webhook Endpoint URL")
 	flags.StringVarP(&opts.PayloadFormat, "payload-format", "", "", "Payload Format (Default, CloudEvents)")
 	flags.StringVarP(&opts.AuthHeader, "auth-header", "", "", "Authentication Header")

cmd/harbor/root/webhook/delete.go

@@ -82,14 +82,14 @@ or interactively select a project and webhook if not provided.`,
 				return fmt.Errorf("failed to delete webhook: %w", err)
 			}
 
-			fmt.Printf("✅ Webhook deleted successfully from project '%s'\n", projectName)
+			fmt.Printf("Webhook deleted successfully from project '%s'\n", projectName)
 			return nil
 		},
 	}
 
 	flags := cmd.Flags()
 	flags.StringVarP(&projectName, "project", "", "", "Project name (required when providing webhook ID or name)")
-	flags.Int64VarP(&webhookId, "webhook", "", -1, "Webhook ID (alternative to providing webhook name as argument)")
+	flags.Int64VarP(&webhookId, "webhook-id", "", -1, "Webhook ID (alternative to providing webhook name as argument)")
 
 	return cmd
 }

cmd/harbor/root/webhook/edit.go

@@ -100,7 +100,7 @@ or leave them out and use the interactive prompt to select and update a webhook.
 	flags.Int64VarP(&opts.WebhookId, "webhook-id", "", -1, "Webhook ID")
 	flags.StringVarP(&opts.Description, "description", "", "", "Webhook Description")
 	flags.StringVarP(&opts.NotifyType, "notify-type", "", "", "Notify Type (http, slack)")
-	flags.StringArrayVarP(&opts.EventType, "event-type", "", []string{}, "Event Types (comma separated)")
+	flags.StringSliceVarP(&opts.EventType, "event-type", "", []string{}, "Event Types (comma separated)")
 	flags.StringVarP(&opts.EndpointURL, "endpoint-url", "", "", "Webhook Endpoint URL")
 	flags.StringVarP(&opts.PayloadFormat, "payload-format", "", "", "Payload Format (Default, CloudEvents)")
 	flags.StringVarP(&opts.AuthHeader, "auth-header", "", "", "Authentication Header")

pkg/api/webhook_handler.go

@@ -67,7 +67,6 @@ func CreateWebhook(opts *create.CreateView) error {
 	})
 
 	if err != nil {
-		log.Errorf("%s", err)
 		return err
 	}
 
@@ -89,7 +88,6 @@ func DeleteWebhook(projectName string, webhookId int64) error {
 		ProjectNameOrID: projectName,
 	})
 	if err != nil {
-		log.Errorf("%s", err)
 		return err
 	}
 	if response != nil {
@@ -125,7 +123,6 @@ func UpdateWebhook(opts *edit.EditView) error {
 		},
 	})
 	if err != nil {
-		log.Errorf("%s", err)
 		return err
 	}
 	if response != nil {
@@ -145,7 +142,6 @@ func GetWebhookID(projectName string, WebhookName string) (int64, error) {
 	})
 
 	if err != nil {
-		log.Errorf("%s", err)
 		return 0, err
 	}
 
@@ -171,7 +167,6 @@ func GetWebhook(projectName string, webhookId int64) (models.WebhookPolicy, erro
 		XIsResourceName: &IsResourceName,
 	})
 	if err != nil {
-		log.Errorf("%s", err)
 		return models.WebhookPolicy{}, err
 	}
 	return *response.Payload, nil