Proposal: replace "command copy" buttons with plain "artifact URI"

[aljazs-implex]

Is your feature request related to a problem? Please describe.

When copying an artifact "URI" using the copy button, the whole docker pull <artifact> command is copied. This introduces friction when using the copied text in other scenarios (such as helm charts, etc ...)

Describe the solution you'd like

I would like to only copy the artifact path, not the full command.

Describe the main design/architecture of your solution

Change the UI code so it only shows and copies the artifact paths instead of full client commands.

This would also remove the (in my opinion) unnecessary "complexity" of deciding which command should be rendered.

Describe the development plan you've considered

I am ready to create a MR that implements this.

[Orangnoorshamsi]

````#23645

[Vad1mo]

this breaks backward compatibility and what user expect.

what you can do instead is set your "custom" command to e.g. echo, so that the output would be echo pull demo.goharbor.io/11a/busybox:1.0.0

an alternative would be to have an option that would be none

this was is stays backward compatible but the user can still adopt it.

[aljazs-implex]

echo pull <image> is far from the desired outcome.

"none" would have to print out nothing in the prefix, even without pull in the copied command. This will add even more (unnecesary) code.

While I do understand that making breaking changes is - of course - bad, though I would not consider this as a breaking change.
I would argue that [providing full commands] is not needed in the first place, as I stated in the issue description, but I digress.

If you think adding another option to the "pull command prefix" is a valid approach, I can work on and provide a patch.

---

I would also argue that most users would prefer to have no prefix at all.
At least in my closer circlers of coworkers and acquaintances, that are goHarbor users and I have at some point in time discussed with about this issue, have stated that they would prefer just having the artifact path instead of full commands.

[Foosec]

Its a mild annoyance, most of the time "docker pull" is not what i want to do, infact it was never the thing i wanted to do :)
Usually its pasted into compose files, or other files as the image definition.

I support backwards compatibility, maybe editing the prefix so it may be empty would be a good solution?
Or just adding another button to only copy the image url?

[zigatrcek]

Since backward compatibility needs to be maintained, i would suggest moving "pull" into the prefix and appending "pull" into the prefix setting.

by doing that and allowing prefix to be empty, you could have just the artifact path or whatever command you want.