-
-
Notifications
You must be signed in to change notification settings - Fork 7.8k
Add support for native Go implementation of AsciiDoc by using libasciidoc #5672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We're aware of the Cc: @xcoulon |
0.1 may be a little early, yes -- but @xcoulon has been very busy lately. I'm very impressed by his recent work. I'm not familiar with AsciiDoc, so I cannot judge when this has become "good enough", but I can say this:
|
thanks for this PR @odknt, it was actually on my TODO list for a little later, once libasciidoc would have a better support of the Asciidoc syntax. And the plan is actually to use a feature toggle (as you did) to make sure that it's set at an "experimental" level for a bit (while Asciidoctor would remain the default runtime to process the files). Thanks for the feedback @bep! I hope I can get more features soon (as time allows), and we should definitely discuss about the info/metadata that libasciidoc should return upon processing. I'm thinking about the doc title, author and ToC for instance, but there may be also other pieces of info that it should return to integrate nicely in Hugo. |
@bep @moorereason @xcoulon Thanks for checking. May be @moorereason is right. I found issue related asciidoc in hugo and libasciidoc.
Is there a possibility to be merge this PR? |
@odknt if you found a bug in libasciidoc, would you mind opening an issue with a sample content so I can reproduce and fix the bug, please? I probably missed an edge-case with regards to the ToC ;) |
This will have to wait. Mostly to wait for libasciidoc to be a little more mature (it looks really promising). That, and I'm currently working on some restructuring of the relevant code, which will make this integration simpler when this is ready. But thanks for your contribution. |
OK, thanks. |
The ToC bug in libasciidoc was fixed in bytesparadise/libasciidoc#284 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Close #1435
Render asciidoc by using libasciidoc if
useLibasciidoc
is true.