added delete request body support

Author: Gojek

lib/wrest/native/delete.rb

@@ -9,12 +9,12 @@
 
 module Wrest::Native
   class Delete < Request
-    def initialize(wrest_uri, parameters = {}, headers = {}, options = {})
+    def initialize(wrest_uri, body = '', headers = {}, parameters = {} ,options = {})
       super(
             wrest_uri, 
             Net::HTTP::Delete, 
             parameters,
-            nil,
+            body,
             headers,
             options
           )

lib/wrest/uri.rb

@@ -135,8 +135,8 @@ def build_post_form(parameters ={}, headers = {}, &block)
     end
 
     #:nodoc:
-    def build_delete(parameters = {}, headers = {}, &block)
-      Http::Delete.new(self, parameters, default_headers.merge(headers), block ? @options.merge(:callback_block => block) : @options)
+    def build_delete(body = '', headers = {}, parameters = {}, &block)
+      Http::Delete.new(self, body.to_s, default_headers.merge(headers), parameters, block ? @options.merge(:callback_block => block) : @options)
     end
 
     # Make a GET request to this URI. This is a convenience API
@@ -242,8 +242,8 @@ def post_form_async(parameters = {}, headers = {}, &block)
     # that creates a Wrest::Native::Delete, executes it and returns a Wrest::Native::Response.
     #
     # Remember to escape all parameter strings if necessary, using URI.escape
-    def delete(parameters = {}, headers = {}, &block)
-      build_delete(parameters, headers, &block).invoke
+    def delete(parameters = {}, headers = {}, body = '', &block)
+      build_delete(body, headers, parameters, &block).invoke
     end
 
     # Makes a DELETE request to this URI. This is a convenience API
@@ -253,8 +253,8 @@ def delete(parameters = {}, headers = {}, &block)
     #
     # Note: delete_async does not return a response and the response should be accessed through callbacks.
     # This implementation of asynchronous delete is currently in alpha. Hence, it should not be used in production.
-    def delete_async(parameters = {}, headers = {}, &block)
-      @asynchronous_backend.execute(build_delete(parameters, headers, &block))
+    def delete_async(parameters = {}, headers = {}, body = '', &block)
+      @asynchronous_backend.execute(build_delete(body, headers, parameters, &block))
     end
 
     # Makes an OPTIONS request to this URI. This is a convenience API

lib/wrest/version.rb

@@ -8,5 +8,5 @@
 # See the License for the specific language governing permissions and limitations under the License.
 
 module Wrest
-  VERSION = "3.0.0"
+  VERSION = "3.0.1"
 end

spec/wrest/uri_spec.rb

@@ -365,9 +365,9 @@ def setup_http
           request = Net::HTTP::Delete.new('/glassware?owner=Kai&type=bottle', {'page' => '2', 'per_page' => '5'})
           Net::HTTP::Delete.should_receive(:new).with('/glassware?owner=Kai&type=bottle', {'page' => '2', 'per_page' => '5'}).and_return(request)
 
-          http.should_receive(:request).with(request, nil).and_return(build_ok_response(nil))
+          http.should_receive(:request).with(request, '').and_return(build_ok_response(nil))
 
-          uri.delete(build_ordered_hash([[:owner, 'Kai'],[:type, 'bottle']]), :page => '2', :per_page => '5')
+          uri.delete(build_ordered_hash([[:owner, 'Kai'],[:type, 'bottle']]), {:page => '2', :per_page => '5'}, '')
         end
 
         context "query parameters" do
@@ -379,9 +379,9 @@ def setup_http
             request = Net::HTTP::Delete.new('/glassware?owner=Kai&type=bottle', {'page' => '2', 'per_page' => '5'})
             Net::HTTP::Delete.should_receive(:new).with('/glassware?owner=Kai&type=bottle', {'page' => '2', 'per_page' => '5'}).and_return(request)
 
-            http.should_receive(:request).with(request, nil).and_return(build_ok_response(nil))
+            http.should_receive(:request).with(request, '').and_return(build_ok_response(nil))
 
-            uri.delete({}, :page => '2', :per_page => '5')
+            uri.delete({}, {:page => '2', :per_page => '5'}, '')
           end
 
           it "should know how to delete with a ? appended to the uri and no appended parameters" do
@@ -392,9 +392,9 @@ def setup_http
             request = Net::HTTP::Delete.new('/glassware', {'page' => '2', 'per_page' => '5'})
             Net::HTTP::Delete.should_receive(:new).with('/glassware', {'page' => '2', 'per_page' => '5'}).and_return(request)
 
-            http.should_receive(:request).with(request, nil).and_return(build_ok_response(nil))
+            http.should_receive(:request).with(request, '').and_return(build_ok_response(nil))
 
-            uri.delete({}, :page => '2', :per_page => '5')
+            uri.delete({}, {:page => '2', :per_page => '5'}, '')
 
           end
 
@@ -408,9 +408,9 @@ def setup_http
             Net::HTTP::Delete.should_receive(:new).with('/glassware?owner=Kai&type=bottle', {'page' => '2', 'per_page' => '5'}).and_return(request)
 
 
-            http.should_receive(:request).with(request, nil).and_return(build_ok_response(nil))
+            http.should_receive(:request).with(request, '').and_return(build_ok_response(nil))
 
-            uri.delete(build_ordered_hash([[:owner, 'Kai'],[:type, 'bottle']]), :page => '2', :per_page => '5')
+            uri.delete(build_ordered_hash([[:owner, 'Kai'],[:type, 'bottle']]), {:page => '2', :per_page => '5'}, '')
 
           end
 
@@ -423,9 +423,9 @@ def setup_http
 
             Net::HTTP::Delete.should_receive(:new).with('/glassware?owner=kai&type=bottle&param1=one&param2=two', {'page' => '2', 'per_page' => '5'}).and_return(request)
 
-            http.should_receive(:request).with(request, nil).and_return(build_ok_response(nil))
+            http.should_receive(:request).with(request, '').and_return(build_ok_response(nil))
 
-            uri.delete(build_ordered_hash([[:param1, 'one'],[:param2, 'two']]), :page => '2', :per_page => '5')
+            uri.delete(build_ordered_hash([[:param1, 'one'],[:param2, 'two']]), {:page => '2', :per_page => '5'}, '')
           end
         end
       end