refactor: use constant for Trino driver name and clean up code formatting

Author: Sbaia

database/trino/trino.go

@@ -21,6 +21,8 @@ var (
 	ErrNilConfig           = fmt.Errorf("no config")
 )
 
+const TrinoDriverName = "trino"
+
 type Config struct {
 	MigrationsTable   string
 	MigrationsSchema  string
@@ -29,7 +31,7 @@ type Config struct {
 }
 
 func init() {
-	database.Register("trino", &Trino{})
+	database.Register(TrinoDriverName, &Trino{})
 }
 
 func WithInstance(conn *sql.DB, config *Config) (database.Driver, error) {
@@ -67,9 +69,9 @@ func (t *Trino) Open(dsn string) (database.Driver, error) {
 
 	// Filter custom parameters and handle scheme conversion
 	q := migrate.FilterCustomQuery(purl)
-	
+
 	// Convert trino:// scheme to http:// or https:// based on ssl parameter
-	if q.Scheme == "trino" {
+	if q.Scheme == TrinoDriverName {
 		// Check ssl parameter (default is true)
 		ssl := purl.Query().Get("ssl")
 		if ssl == "" || ssl == "true" {
@@ -86,7 +88,7 @@ func (t *Trino) Open(dsn string) (database.Driver, error) {
 	}
 	q.RawQuery = query.Encode()
 
-	conn, err := sql.Open("trino", q.String())
+	conn, err := sql.Open(TrinoDriverName, q.String())
 	if err != nil {
 		return nil, err
 	}

database/trino/trino_test.go

@@ -97,15 +97,15 @@ func isReady(ctx context.Context, c dktest.ContainerInfo) bool {
 			time.Sleep(2 * time.Second)
 			continue
 		}
-		
+
 		// Test a simple query to ensure Trino is fully ready
 		var result int
 		if err = db.QueryRowContext(readyCtx, "SELECT 1").Scan(&result); err != nil {
 			log.Printf("trino query test attempt %d error: %v", i+1, err)
 			time.Sleep(2 * time.Second)
 			continue
 		}
-		
+
 		log.Printf("trino ready after %d attempts", i+1)
 		// Give Trino a moment to stabilize before tests start
 		time.Sleep(3 * time.Second)
@@ -333,7 +333,7 @@ func TestTrinoSchemeConversion(t *testing.T) {
 			if err != nil {
 				t.Fatal(err)
 			}
-			
+
 			// Apply the same logic as in the Open function
 			q := migrate.FilterCustomQuery(purl)
 			if q.Scheme == "trino" {
@@ -344,7 +344,7 @@ func TestTrinoSchemeConversion(t *testing.T) {
 					q.Scheme = "http"
 				}
 			}
-			
+
 			if q.Scheme != tc.expectedScheme {
 				t.Errorf("Expected scheme %s, got %s for URL %s", tc.expectedScheme, q.Scheme, tc.inputURL)
 			}
@@ -367,7 +367,7 @@ func TestTrinoLockConcurrency(t *testing.T) {
 		if err != nil {
 			t.Fatal(err)
 		}
-		defer d.Close()
+		defer func() { _ = d.Close() }()
 
 		// Test basic locking functionality
 		if err := d.Lock(); err != nil {