Merge pull request #1070 from certifaction/mysql-safe-update

dhui · web-flow · commit 04b36ebaac41 · 2024-04-29T21:59:22.000-07:00
Make MySQL SetVersion compatible with sql_safe_update
diff --git a/database/mysql/mysql.go b/database/mysql/mysql.go
@@ -361,7 +361,7 @@ func (m *Mysql) SetVersion(version int, dirty bool) error {
 		return &database.Error{OrigErr: err, Err: "transaction start failed"}
 	}
 
-	query := "DELETE FROM `" + m.config.MigrationsTable + "`"
+	query := "DELETE FROM `" + m.config.MigrationsTable + "` LIMIT 1"
 	if _, err := tx.ExecContext(context.Background(), query); err != nil {
 		if errRollback := tx.Rollback(); errRollback != nil {
 			err = multierror.Append(err, errRollback)

Original file line number	Diff line number	Diff line change
`@@ -361,7 +361,7 @@ func (m *Mysql) SetVersion(version int, dirty bool) error {`
`361`	`361`	`return &database.Error{OrigErr: err, Err: "transaction start failed"}`
`362`	`362`	`}`
`363`	`363`
`364`		- query := "DELETE FROM `" + m.config.MigrationsTable + "`"
	`364`	+ query := "DELETE FROM `" + m.config.MigrationsTable + "` LIMIT 1"
`365`	`365`	`if _, err := tx.ExecContext(context.Background(), query); err != nil {`
`366`	`366`	`if errRollback := tx.Rollback(); errRollback != nil {`
`367`	`367`	`err = multierror.Append(err, errRollback)`