Skip to content

Commit a7cbeca

Browse files
jbagopherbot
authored andcommitted
tests/screentest: relax pixel diffs on some tests
Use the new feature in screentest to make the retrypixels value larger for certain tests that tend to fail. We need the version of screentest at master because it hasn't been tagged yet. Change-Id: I68770f1d111895ae6c1a460599e9e6b4ee90f369 Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/811800 Reviewed-by: Ethan Lee <ethanalee@google.com> Auto-Submit: Jonathan Amsterdam <jba@google.com> LUCI-TryBot-Result: golang-scoped@luci-project-accounts.iam.gserviceaccount.com <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> kokoro-CI: kokoro <noreply+kokoro@google.com>
1 parent d29292e commit a7cbeca

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

tests/screentest/run.sh

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,10 @@ source devtools/docker.sh || { echo "Are you at repo root?"; exit 1; }
1313
# Do not truncate commands when displaying them (see runcmd in devtools/lib.sh).
1414
MAXWIDTH=0
1515

16-
screentest_version=latest
16+
# Use the commit containing per-test retrypixels.
17+
# TODO: Change back to latest when this commit is under a tag
18+
# in x/website.
19+
screentest_version=1137bfaf
1720

1821
# This should match the version we are using in devtools/docker/compose.yaml.
1922
chromedp_version=131.0.6778.33

tests/screentest/testcases.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,6 +161,7 @@ capture viewport 540x1080
161161
# So do a viewport capture instead.
162162
test package with deprecated symbols index
163163
path /database/sql/driver@go1.16.3#pkg-index
164+
retrypixels 50
164165
wait {{$ready}}
165166
eval {{$hideElements}}
166167
sleep 2s
@@ -172,6 +173,7 @@ capture viewport
172173
# Same as the above, but for symbol doc.
173174
test package with deprecated symbols symbol
174175
path /database/sql/driver@go1.16.3#ColumnConverter
176+
retrypixels 50
175177
wait {{$ready}}
176178
eval {{$hideElements}}
177179
sleep 1s

0 commit comments

Comments
 (0)