Skip to content

Commit e314822

Browse files
suzmuesuzmue
committed
[release] prepare v0.35.2 release
073136d CHANGELOG.md: update for v0.35.2 8e5969f src/goToolsInformation: pick up gopls release 55683f5 src/goToolsInformation: update hardcoded gopls version 886decb tools: generate inlay hints settings from gopls settings 7467f26 README: edit Quickstart and Features section for clarity e4a94d2 .github/workflows: fix wiki.yml 84fe4e7 .github/workflows: add go1.19rc2 to long/smoke tests d114767 commands: add go.goroot command 484a3ba test/gopls/vulncheck: add logging for viewer test failure 5bf7237 test/integration/extension: disable all "Test Completion Snippets *" f4fcd7a test/integration/goDebug: make invalid flag test faster cbecbf8 test/integration/goExplorer: fix 'env tree items' test e91d0e8 test/integration/install: stub languageserver restart command a6729ef test/integration/goDebug: speed up setUpRemoteProgram 78c2fac Revert "src/goInstallTools: show error if go.languageserver.restart fails" aa3de7f test/integration: catch failed await in lint test b90e57e .vscode/launch.json: remove outFiles and deprecated attributes d2afd7d src/goTest/resolve: fix nested packageDisplayMode handling on win32 47f6dfa test/integration/goTest: fix populateModulePathCache 1adebbb test/integration/goTest.run: increase discover&run timeout ffae001 test/integration/goDebug: skip redundant tests in withConsole mode c909738 test/integration/goDebug: skip legacy da testing on windows a39ef24 package.json: remove tslint 1dfac14 .github/workflows: drop 1.15 from long test 944b1d4 .github/workflows: remove 'stable' unnecessary in setup-go@v3 21bbd7b test: skip flaky debug test 305bea7 .github/workflows: upgrade setup-go to v3 and enable caching b6aad3e .github/workflows: upgrade checkout/node workflows to v3 9bb57d8 test/integration: skip tests broken on windows b012df4 src/goInstallTools: show error if go.languageserver.restart fails c8598b1 test/integration/goDebug: catch any error while cleaning up 8f6cb5d goGenerateTests: resolve config file path aba3079 CHANGELOG.md: add v0.35.1 description bfdb91c package.json: update dev version 4bd0f33 docs/debugging.md: fix missing "" in example Change-Id: I7504ae5e6d9c40009ad0feb6317f7f1000987012
2 parents 5e111fe + 073136d commit e314822

33 files changed

+596
-645
lines changed

‎.github/workflows/release-nightly.yml

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,17 +18,20 @@ jobs:
1818

1919
steps:
2020
- name: Clone repository
21-
uses: actions/checkout@v2
21+
uses: actions/checkout@v3
2222

2323
- name: Setup Node
24-
uses: actions/setup-node@v1
24+
uses: actions/setup-node@v3
2525
with:
26-
node-version: '14.x'
26+
node-version: '16'
27+
cache: 'npm'
2728

2829
- name: Setup Go
29-
uses: actions/setup-go@v2
30+
uses: actions/setup-go@v3
3031
with:
31-
go-version: '1.18'
32+
go-version: '1.19'
33+
check-latest: true
34+
cache: true
3235

3336
- name: Install dependencies
3437
run: npm ci

‎.github/workflows/release.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,8 +37,14 @@ jobs:
3737
if: github.repository == 'golang/vscode-go'
3838

3939
steps:
40-
- name: checkout code
41-
uses: actions/checkout@v2
40+
- name: Clone repository
41+
uses: actions/checkout@v3
42+
43+
- name: Setup Node
44+
uses: actions/setup-node@v3
45+
with:
46+
node-version: '16'
47+
cache: 'npm'
4248

4349
- name: get release version
4450
id: release_version

‎.github/workflows/test-long-all.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,22 +17,24 @@ jobs:
1717
matrix:
1818
os: [ubuntu-latest, windows-latest, macos-latest]
1919
version: ['stable', 'insiders']
20-
go: ['1.15', '1.16', '1.17', '1.18']
20+
go: ['1.16', '1.17', '1.18', '1.19']
2121

2222
steps:
2323
- name: Clone repository
24-
uses: actions/checkout@v2
24+
uses: actions/checkout@v3
2525

2626
- name: Setup Node
27-
uses: actions/setup-node@v1
27+
uses: actions/setup-node@v3
2828
with:
29-
node-version: '14.x'
29+
node-version: '16'
30+
cache: 'npm'
3031

3132
- name: Setup Go
32-
uses: actions/setup-go@v2
33+
uses: actions/setup-go@v3
3334
with:
3435
go-version: ${{ matrix.go }}
35-
stable: '!contains(${{ matrix.go }}, "beta") && !contains(${{ matrix.go }}, "rc")'
36+
check-latest: true
37+
cache: true
3638

3739
- name: Install dependencies
3840
run: npm ci

‎.github/workflows/test-long.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,24 @@ jobs:
1616
matrix:
1717
os: [ubuntu-latest, windows-latest] # TODO: reenable macos-latest
1818
version: ['stable']
19-
go: ['1.15', '1.16', '1.17', '1.18']
19+
go: ['1.16', '1.17', '1.18', '1.19']
2020

2121
steps:
2222
- name: Clone repository
23-
uses: actions/checkout@v2
23+
uses: actions/checkout@v3
2424

2525
- name: Setup Node
26-
uses: actions/setup-node@v1
26+
uses: actions/setup-node@v3
2727
with:
28-
node-version: '14.x'
28+
node-version: '16'
29+
cache: 'npm'
2930

3031
- name: Setup Go
31-
uses: actions/setup-go@v2
32+
uses: actions/setup-go@v3
3233
with:
3334
go-version: ${{ matrix.go }}
34-
stable: '!contains(${{ matrix.go }}, "beta") && !contains(${{ matrix.go }}, "rc")'
35+
check-latest: true
36+
cache: true
3537

3638
- name: Install dependencies
3739
run: npm ci

‎.github/workflows/test-smoke.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,22 +14,25 @@ jobs:
1414
strategy:
1515
fail-fast: false
1616
matrix:
17-
os: [ubuntu-latest]
17+
os: [ubuntu-latest, windows-latest]
1818
version: ['stable']
1919

2020
steps:
2121
- name: Clone repository
22-
uses: actions/checkout@v2
22+
uses: actions/checkout@v3
2323

2424
- name: Setup Node
25-
uses: actions/setup-node@v1
25+
uses: actions/setup-node@v3
2626
with:
27-
node-version: '14.x'
27+
node-version: '16'
28+
cache: 'npm'
2829

2930
- name: Setup Go
30-
uses: actions/setup-go@v2
31+
uses: actions/setup-go@v3
3132
with:
32-
go-version: '1.18'
33+
go-version: '1.19.0'
34+
check-latest: true
35+
cache: true
3336

3437
- name: Install dependencies
3538
run: npm ci

‎.github/workflows/wiki.yml

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ on:
66
branches: [ master ]
77
paths:
88
- 'docs/**'
9+
- '.github/workflows/wiki.yml'
910

1011
# A workflow run is made up of one or more jobs that can run sequentially or in parallel
1112
permissions:
@@ -32,7 +33,13 @@ jobs:
3233
repository: ${{github.repository}}.wiki
3334
path: wiki
3435
- name: Setup Go
35-
uses: actions/setup-go@v2
36+
uses: actions/setup-go@v3
37+
with:
38+
go-version: '1.19'
39+
check-latest: true
40+
cache: true
41+
cache-dependency-path: '**/go.sum'
42+
3643
- name: Push to wiki
3744
run: |
3845
cd vscode-go

‎.vscode/launch.json

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
"outFiles": [
2323
"${workspaceFolder}/dist/**/*.js"
2424
],
25-
"stopOnEntry": false,
2625
"sourceMaps": true,
2726
"smartStep": true,
2827
"preLaunchTask": "npm: bundle-dev",
@@ -33,7 +32,6 @@
3332
{
3433
"name": "Launch as server",
3534
"type": "node",
36-
"protocol": "inspector",
3735
"request": "launch",
3836
"program": "${workspaceFolder}/dist/debugAdapter.js",
3937
"args": [
@@ -64,14 +62,9 @@
6462
"VSCODE_GO_IN_TEST": "1", // Disable code that shouldn't be used in test
6563
"MOCHA_TIMEOUT": "999999",
6664
},
67-
"stopOnEntry": false,
6865
"sourceMaps": true,
6966
"smartStep": true,
70-
"outFiles": [
71-
"${workspaceFolder}/out/**/*.js",
72-
"${workspaceFolder}/out/test/**/*.js"
73-
],
74-
"preLaunchTask": "npm: watch"
67+
"preLaunchTask": "npm: watch",
7568
},
7669
{
7770
"name": "Launch Extension Tests with Gopls",
@@ -89,12 +82,7 @@
8982
"env": {
9083
"VSCODE_GO_IN_TEST": "1" // Disable code that shouldn't be used in test
9184
},
92-
"stopOnEntry": false,
9385
"sourceMaps": true,
94-
"outFiles": [
95-
"${workspaceFolder}/out/**/*.js",
96-
"${workspaceFolder}/out/test/**/*.js"
97-
],
9886
"preLaunchTask": "npm: watch",
9987
},
10088
{

‎CHANGELOG.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,14 @@
1+
## v0.35.2 - 15 Aug, 2022
2+
A list of all issues and changes can be found in the [v0.35.2 milestone](https://github.com/golang/vscode-go/milestone/51) and [commit history](https://github.com/golang/vscode-go/compare/v0.35.1...v0.35.2).
3+
4+
### Changes
5+
6+
This release includes a new [go.goroot command](https://github.com/golang/vscode-go/issues/2379), [fixes](https://github.com/golang/vscode-go/issues/2342) to the `Generate Tests` commands, and improvements for windows users.
7+
8+
### Thanks
9+
10+
Thank you for your contribution, @OrBin, @Ras96, @hyangah, @jamalcarvalho, and @suzmue!
11+
112
## v0.35.1 - 19 July, 2022
213

314
A list of all issues and changes can be found in the [v0.35.1 milestone](https://github.com/golang/vscode-go/milestone/50) and [commit history](https://github.com/golang/vscode-go/compare/v0.35.0...v0.35.1).

‎README.md

Lines changed: 37 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,22 @@ Welcome! 👋🏻<br/>
2424
Whether you are new to Go or an experienced Go developer, we hope this
2525
extension fits your needs and enhances your development experience.
2626

27-
* **Step 1.** If you haven't done so already, install [Go](https://golang.org)
28-
and the [VS Code Go extension].
29-
* [Go installation guide]. This extension works best with Go 1.14+.
30-
* [Managing extensions in VS Code].
31-
* **Step 2.** To activate the extension, open any directory or workspace
32-
containing Go code. Once activated, the [Go status bar](https://github.com/golang/vscode-go/wiki/ui) will
33-
appear in the bottom left corner of the window and show the recognized Go
34-
version.
35-
* **Step 3.** The extension depends on [a set of extra command-line tools](#tools).
36-
If they are missing, the extension will show the "⚠️ Analysis Tools Missing"
37-
warning. Click the notification to complete the installation.
27+
1. Install [Go](https://golang.org) 1.14 or newer if you haven't already.
28+
29+
1. Install the [VS Code Go extension].
30+
31+
1. Open any directory or workspace containing Go code to automatically activate
32+
the extension. The
33+
[Go status bar](https://github.com/golang/vscode-go/wiki/ui) appears in the
34+
bottom left corner of the window and displays your Go version.
35+
36+
1. The extension depends on `go`, `gopls`, `dlv` and other optional tools. If
37+
any of the dependencies are missing, the ⚠️ `Analysis Tools Missing` warning
38+
is displayed. Click on the warning to download dependencies.
39+
40+
See the
41+
[tools documentation](https://github.com/golang/vscode-go/wiki/tools) for a
42+
complete list of tools the extension depends on.
3843

3944
<p align="center">
4045
<img src="docs/images/installtools.gif" width=75%>
@@ -44,23 +49,32 @@ extension fits your needs and enhances your development experience.
4449

4550
You are ready to Go :-) &nbsp;&nbsp; 🎉🎉🎉
4651

47-
Please be sure to learn more about the many [features](#features) of this
48-
extension, as well as how to [customize](#customization) them. Take a look at
49-
[Troubleshooting](https://github.com/golang/vscode-go/wiki/troubleshooting) and [Help](#ask-for-help) for further
50-
guidance.
52+
## What's next
53+
54+
* Explore more [features](#features) of the VS Code Go extension.
55+
* Learn how to [customize](#customization) your settings.
56+
* Solve issues with
57+
[Troubleshooting](https://github.com/golang/vscode-go/wiki/troubleshooting).
58+
* [file an issue](https://github.com/golang/vscode-go/issues/new/choose) for
59+
problems with the extension.
60+
* Start a [GitHub discussion](https://github.com/golang/vscode-go/discussions)
61+
or get help on [Stack Overflow].
5162

5263
If you are new to Go, [this article](https://golang.org/doc/code.html) provides
5364
the overview on Go code organization and basic `go` commands. Watch ["Getting
5465
started with VS Code Go"] for an explanation of how to build your first Go
5566
application using VS Code Go.
5667

57-
## Features
68+
## Feature highlights
69+
70+
* [IntelliSense] - Results appear for symbols as you type.
71+
* [Code navigation] - Jump to or peek at a symbol's declaration.
72+
* [Code editing] - Support for saved snippets, formatting and code organization,
73+
and automatic organization of imports.
74+
* [Diagnostics] - Build, vet, and lint errors shown as you type or on save.
75+
* Enhanced support for [testing] and [debugging]
5876

59-
This extension provides many features, including [IntelliSense],
60-
[code navigation], and [code editing] support. It also shows [diagnostics] as
61-
you work and provides enhanced support for [testing] and [debugging] your
62-
programs. See the [full feature breakdown] for more details and to learn how to
63-
tune its behavior.
77+
See the [full feature breakdown] for more details.
6478

6579
<p align=center>
6680
<img src="docs/images/completion-signature-help.gif" width=75%>
@@ -182,8 +196,8 @@ conduct-related issue, please mail [email protected].
182196
[Go installation guide]: https://golang.org/doc/install
183197
["Getting started with VS Code Go"]: https://youtu.be/1MXIGYrMk80
184198
[IntelliSense]: https://github.com/golang/vscode-go/wiki/features#intellisense
185-
[code navigation]: https://github.com/golang/vscode-go/wiki/features#code-navigation
186-
[code editing]: https://github.com/golang/vscode-go/wiki/features#code-editing
199+
[Code navigation]: https://github.com/golang/vscode-go/wiki/features#code-navigation
200+
[Code editing]: https://github.com/golang/vscode-go/wiki/features#code-editing
187201
[diagnostics]: https://github.com/golang/vscode-go/wiki/features#diagnostics
188202
[testing]: https://github.com/golang/vscode-go/wiki/features#run-and-test-in-the-editor
189203
[debugging]: https://github.com/golang/vscode-go/wiki/debugging#features

‎docs/commands.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,10 @@ Finally, you can also see a full list by using a meta command: `Go: Show All Com
2727

2828
See the currently set GOPATH.
2929

30+
### `Go: Current GOROOT`
31+
32+
See the currently set GOROOT.
33+
3034
### `Go: Locate Configured Go Tools`
3135

3236
List all the Go tools being used by this extension along with their locations.

‎docs/debugging-legacy.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -143,7 +143,7 @@ in your launch configuration. This property supports multiple tags, which you ca
143143

144144
### Specifying other build flags
145145

146-
The flags specified in `buildFlags` and `env.GOFLAGS` are passed to the Go compiler when building your program for debugging. Delve adds `-gcflags='all=-N -l'` to the list of build flags to disable optimizations. User specified buildFlags conflict with this setting, so the extension removes them ([Issue #117](https://github.com/golang/vscode-go/issues/117)). If you wish to debug a program using custom `-gcflags`, build the program using `go build` and launch using `exec` mode:
146+
The flags specified in `buildFlags` and `env.GOFLAGS` are passed to the Go compiler when building your program for debugging. Delve adds `-gcflags=all="-N -l"` to the list of build flags to disable optimizations. User specified buildFlags conflict with this setting, so the extension removes them ([Issue #117](https://github.com/golang/vscode-go/issues/117)). If you wish to debug a program using custom `-gcflags`, build the program using `go build` and launch using `exec` mode:
147147

148148
```json
149149
{

‎docs/debugging.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -568,7 +568,7 @@ Start a `dlv dap` server ready to accept a client request to launch or attach to
568568
$ dlv dap --listen=:12345
569569
```
570570

571-
Use the following `launch` configuration to tell `dlv` to execute a binary precompiled with `go build -gcflags='all=-N -l'`:
571+
Use the following `launch` configuration to tell `dlv` to execute a binary precompiled with `go build -gcflags=all="-N -l"`:
572572

573573
```json5
574574
{
@@ -581,7 +581,7 @@ Use the following `launch` configuration to tell `dlv` to execute a binary preco
581581
"mode": "exec",
582582
"program": "/absolute/path/to/remote/workspace/program/executable",
583583
"substitutePath": [
584-
{ "from": ${workspaceFolder}, "to": "/path/to/remote/workspace" },
584+
{ "from": "${workspaceFolder}", "to": "/path/to/remote/workspace" },
585585
...
586586
]
587587
}
@@ -655,7 +655,7 @@ The "debug test" CodeLens and the [test UI](features.md#test-and-benchmark) do n
655655

656656
### Starting a debug session fails with `decoding dwarf section info at offset 0x0: too short` or `could not open debug info` error.
657657

658-
These errors indicate that your binary was built with linker flags that stripped the symbol table (`-s`) or the DWARF debug information (`-w`), making debugging impossible. If the binary is built while launching the session, make sure your `launch.json` configuration does not contain `"buildFlags": "--ldflags '-s -w'"`. If you use `debug test` or Test Explorer, check `go.buildFlags` in `settings.json`. If the binary is built externally, check the command-line flags and do not use `go run`. Unlike `go build`, `go run` passes `-s -w` to the linker under the hood. If you try to attach to such a binary with a debugger, it will fail with one of the above errors (see Go Issue [24833](https://github.com/golang/go/issues/24833)). Instead let dlv build the binary for you or use `go build -gcflags='all=-N -l'`.
658+
These errors indicate that your binary was built with linker flags that stripped the symbol table (`-s`) or the DWARF debug information (`-w`), making debugging impossible. If the binary is built while launching the session, make sure your `launch.json` configuration does not contain `"buildFlags": "--ldflags '-s -w'"`. If you use `debug test` or Test Explorer, check `go.buildFlags` in `settings.json`. If the binary is built externally, check the command-line flags and do not use `go run`. Unlike `go build`, `go run` passes `-s -w` to the linker under the hood. If you try to attach to such a binary with a debugger, it will fail with one of the above errors (see Go Issue [24833](https://github.com/golang/go/issues/24833)). Instead let dlv build the binary for you or use `go build -gcflags=all="-N -l"`.
659659

660660
## Reporting Issues
661661

0 commit comments

Comments
 (0)