1.33.0: "File exists" errors when un-taring golangci-lint

[andig]

I'm using the linter action in https://github.com/andig/evcc/pull/497/checks?check_run_id=1474850871:

Go artefacts are already cached:

steps:
- name: Setup
  uses: actions/setup-go@v2
  with:
    go-version: ^1.14
  id: go

- uses: actions/cache@v2
  with:
    path: |
      ~/go/pkg/mod
      **/node_modules
    key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}-${{ hashFiles('**/package-lock.json') }}
    restore-keys: |
      ${{ runner.os }}-go-

...

- name: Lint
  uses: golangci/golangci-lint-action@v2
  with:
    version: v1.33

This leads to large amount of errors in the action log:

Installed Go in 79ms
Requested golangci-lint 'v1.33', using 'v1.33.0', calculation took 226ms
Installing golangci-lint v1.33.0...
Downloading https://github.com/golangci/golangci-lint/releases/download/v1.33.0/golangci-lint-1.33.0-linux-amd64.tar.gz ...
Received 92009212 of 92009212 (100.0%), 146.0 MBs/sec
Cache Size: ~88 MB (92009212 B)
/bin/tar --use-compress-program zstd -d -xf /home/runner/work/_temp/1fe13742-cdde-4fcd-88d4-a1bcad1244b3/cache.tzst -P -C /home/runner/work/evcc/evcc
/bin/tar xz --warning=no-unknown-keyword -C /home/runner -f /home/runner/work/_temp/11aa6afa-628a-4b5d-94a5-40d55abea5bd
Error: /bin/tar: ../../../go/pkg/mod/gopkg.in/ini.v1@v1.62.0/ini.go: Cannot open: File exists
Error: /bin/tar: ../../../go/pkg/mod/gopkg.in/ini.v1@v1.62.0/bench_test.go: Cannot open: File exists
...
Error: /bin/tar: ../../../go/pkg/mod/golang.org/x/mod@v0.3.0/modfile/rule.go: Cannot open: File exists
Error: /bin/tar: ../../../go/pkg/mod/golang.org/x/mod@v0.3.0/modfile/print.go: Cannot open: File exists
/bin/tar: Exiting with failure status due to previous errors
Warning: Tar failed with error: The process '/bin/tar' failed with exit code 2
Prepared env in 3125ms

[dahu33]

I have the same issue.

[h4yfans]

Same!

[phillbaker]

Perhaps installLint should return early if the install path already exists?

golangci-lint-action/src/run.ts

Line 19 in 54a84d4

return await installLint(versionConfig)

[nicovogelaar]

A workaround is to run this before:

go clean -modcache

[andig]

Thats not acceptable imho. The expectation of finding a clean modcache is wrong.

[NomNes]

I have the same issue, but only on self-hosted runner

[gabizou]

I'm running into this issue after having something like this as a run file (using protoc to generate models)

name: "golangci-lint report"
on:
    push:
        branches:
            - main
    pull_request:
        branches:
            - main
jobs:
    setup:
        runs-on: ubuntu-latest
        steps:
            -   uses: actions/checkout@v2

            -   name: Set up Go
                uses: actions/setup-go@v2
                with:
                    go-version: 1.15
            -   name: Install Protoc
                uses: arduino/setup-protoc@v1
                with:
                    version: '3.14'
            -   name: Cache dependencies
                uses: actions/cache@v2
                with:
                    path: |
                        .go/cache
                        ./gen
                    key: ${{ runner.os }}-${{ hashFiles('./go.mod') }}
            -   name: Add protoc to path
                run: |
                    echo "$GOPATH"
                    echo "$GOPATH/bin" >> $GITHUB_PATH
                    echo "$PATH"
                    go get -u github.com/golang/protobuf/protoc-gen-go
            -   name: Setup generated code
                run: |
                    make setup
            -   name: golangci-lint
                uses: golangci/golangci-lint-action@v2
                with:
                    # Required: the version of golangci-lint is required and must be specified without patch version: we always use the latest patch version.
                    version: v1.34
                    args: -v --timeout=5m

The trouble is that our makefile does set up the code generation with both go generate and protoc. Any advice? I'm struggling to find a happy medium for having code generation and linting in actions.

[andig]

It seems the issue has been around for some time and accepted as being an issue with the linter action: linter expects module cache as clean which is not reasonable. Workarounds like cleaning the module cache appear undesirable regarding performance.

Is there anything missing in terms of transparency or input to move this into fixing?

[SVilgelm]

The issue should be fixed by #156 , but there is an issue with macOs