[codex] Validate model tool calls#31
Closed
gold-silver-copper wants to merge 10 commits into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PromptError::UnknownToolCallbefore hooks, tool execution, or tool-result feedback in both prompt paths..tool(...).hook(...).build()and cover it with a compile regression test.Root Cause
Rig trusted structured tool calls too late in the prompt loop. If a provider/model emitted a tool name Rig had not advertised for the current request, the call could proceed into normal hook/tool handling and corrupt the multi-turn state. For Gemini streaming this could show up later as an empty final response warning rather than the real protocol error.
Validation
cargo fmtcargo check -p rig-corecargo test -p rig-core agent::prompt_request::cargo test -p rig-core providers::gemini::cargo test -p rig-core hook_can_be_set_after_tool_configuration