Genric message

Author: goldbergyoni

README.md

@@ -16,7 +16,7 @@ export const startWebServer = (): Promise<AddressInfo> => {
     expressApp.use(
       bodyParser.urlencoded({
         extended: true,
-      })
+      }),
     );
     expressApp.use(bodyParser.json());
     expressApp.use(authenticationMiddleware);
@@ -50,18 +50,18 @@ const defineRoutes = (expressApp: express.Application) => {
     async (
       req: express.Request,
       res: express.Response,
-      next: express.NextFunction
+      next: express.NextFunction,
     ) => {
       try {
         console.log(
-          `Order API was called to add new Order ${util.inspect(req.body)}`
+          `Order API was called to add new Order ${util.inspect(req.body)}`,
         );
         const addOrderResponse = await orderService.addOrder(req.body);
         return res.json(addOrderResponse);
       } catch (error) {
         next(error);
       }
-    }
+    },
   );
 
   // get existing order by id
@@ -92,7 +92,7 @@ const defineRoutes = (expressApp: express.Application) => {
       error: unknown,
       _req: express.Request,
       res: express.Response,
-      _next: express.NextFunction
+      _next: express.NextFunction,
     ) => {
       if (!error || typeof error !== 'object') {
         await errorHandler.handleError(error);
@@ -106,7 +106,7 @@ const defineRoutes = (expressApp: express.Application) => {
       }
       await errorHandler.handleError(richError);
       res.status(status as number).end();
-    }
+    },
   );
 };
 

example-application/entry-points/api.ts

@@ -125,16 +125,18 @@ describe('Error Handling', () => {
     });
   });
   describe('Various Throwing Scenarios And Locations', () => {
-    test('When unhandled exception is throw, Then the logger reports correctly', async () => {
+    test('When unhandled exception is throw, Then the logger+process exit reports correctly', async () => {
       //Arrange
       const loggerDouble = sinon.stub(logger, 'error');
       const errorToThrow = new Error('An error that wont be caught 😳');
+      const processExitListener = sinon.stub(process, 'exit');
 
       //Act
       process.emit('uncaughtException', errorToThrow);
 
       // Assert
       expect(loggerDouble.lastCall.firstArg).toMatchObject(errorToThrow);
+      expect(processExitListener.called).toBe(true);
     });
 
     test.todo(

example-application/test/createOrder.observabilityCheck.test.ts

@@ -1,3 +1,4 @@
+import sinon from 'sinon';
 import { buildOrder } from './order-data-factory';
 import { testSetup } from './setup/test-file-setup';
 
@@ -87,6 +88,7 @@ describe('POST /orders', () => {
     expect(orderAddResult.status).toBe(401);
   });
 
+
   test('When ordered by a premium user, Then 10% discount is applied', async () => {
     //Arrange
     // ️️️✅ Best Practice: Use a dynamic factory to craft big payloads and still clarify which specific details

example-application/test/createOrder.responseCheck.test.ts

@@ -0,0 +1,82 @@
+import { randomBytes } from 'crypto';
+import 'jest-extended';
+
+// Test helper
+function buildWorkflowPreviewResponse(
+  ...workflows: { workflowType: string; status: string }[]
+) {
+  const idsMap: Record<string, any> = {};
+
+  for (let index = 0; index < workflows.length; index++) {
+    const workflow = workflows[index];
+    const randomId = randomBytes(16).toString('hex');
+    idsMap[randomId] = {
+      WorkflowExcution: {
+        WorkflowType: workflow.workflowType,
+        status: workflow.status,
+      },
+      originKey: null,
+      originWorkflowType: null,
+    };
+  }
+
+  return {
+    rootId: expect.any(String),
+    idsMap,
+  };
+}
+
+function buildWorkflowExecution(workflowExecution: {
+  workflowType: string;
+  status: string;
+}) {
+  return {
+    WorkflowExcution: {
+      WorkflowType: workflowExecution.workflowType,
+      status: workflowExecution.status,
+    },
+    originKey: null,
+    originWorkflowType: null,
+  };
+}
+
+const codeUnderTest = () => {
+  return {
+    rootId: '123e4567-e89b-12d3-a456-426614174000',
+    idsMap: {
+      // Note: this is random uuid
+      '123e4567-e89b-12d3-a456-426614172000': {
+        WorkflowExcution: {
+          WorkflowType: 'trustee',
+          status: 'Draft',
+        },
+        originKey: null,
+        originWorkflowType: null,
+      },
+      // Note: this is random uuid
+      '762e4567-e89b-12d3-a456-426614172000': {
+        WorkflowExcution: {
+          WorkflowType: 'award-letter',
+          status: 'Draft',
+        },
+        originKey: null,
+        originWorkflowType: null,
+      },
+    },
+  };
+};
+
+test('foo', () => {
+  // Arrange
+
+  //Act
+  const receivedResult = codeUnderTest();
+
+  // Assert
+  const workflowExecutions = Object.values(receivedResult.idsMap);
+  expect(workflowExecutions).toIncludeAllPartialMembers([
+    buildWorkflowExecution({ workflowType: 'award-letter', status: 'Draft' }),
+    buildWorkflowExecution({ workflowType: 'trustee', status: 'Draft' }),
+    
+  ]);
+});

example-application/test/fooo.test.ts

@@ -59,7 +59,6 @@ test('When order failed, send mail to admin', async () => {
   });
 });
 
-
 // ️️️✅ Best Practice: Check external calls
 test('When adding a new valid order, Then an email should be send to admin', async () => {
   //Arrange

example-application/test/pool.ts

@@ -12,6 +12,7 @@ module.exports = {
   coverageReporters: ['text-summary', 'lcov'],
   collectCoverageFrom: ['**/*.js', '!**/node_modules/**', '!**/test/**'],
   forceExit: true,
+  setupFilesAfterEnv: ['jest-extended/all'],
   testEnvironment: 'node',
   notify: true,
   globalSetup: './example-application/test/setup/global-setup.js',