Merge pull request #11 from ajroetker/modernize-tool-run-001

Apply Go modernize tool fixes

Author: janpfeifer

internal/cmd/dtypes_codegen/enums.go

@@ -148,7 +148,7 @@ func generateEnums(contents string) {
 	if len(matches) == 0 {
 		panicf("failed to match PJRT_Buffer_Types enum from pjrt_c_api.h")
 	}
-	for _, line := range strings.Split(matches[2], "\n") {
+	for line := range strings.SplitSeq(matches[2], "\n") {
 		if line == "" {
 			continue
 		}

internal/cmd/pjrt_codegen/enums.go

@@ -63,7 +63,7 @@ func generateEnums(contents string) {
 			continue
 		}
 		var eEntry *enumEntry
-		for _, line := range strings.Split(matches[2], "\n") {
+		for line := range strings.SplitSeq(matches[2], "\n") {
 			if line == "" {
 				continue
 			}

internal/pool/pool_test.go

@@ -33,10 +33,10 @@ func TestPool(t *testing.T) {
 	var wg sync.WaitGroup
 	wg.Add(numGoroutines)
 
-	for i := 0; i < numGoroutines; i++ {
+	for range numGoroutines {
 		go func() {
 			defer wg.Done()
-			for j := 0; j < numIterations; j++ {
+			for range numIterations {
 				node := pool.Get()
 
 				// Simulate work

internal/shapeinference/shapeinference.go

@@ -828,7 +828,7 @@ func Concatenate(inputs []shapes.Shape, axis int) (output shapes.Shape, err erro
 				rank, i, currentShape.Rank())
 		}
 
-		for d := 0; d < rank; d++ {
+		for d := range rank {
 			if d == axis {
 				// For the concatenation axis, add dimensions (handling dynamic dims)
 				if output.Dimensions[d] != shapes.DimUnknown && currentShape.Dimensions[d] != shapes.DimUnknown {
@@ -987,7 +987,7 @@ func Slice(operand shapes.Shape, starts, limits, strides []int) (output shapes.S
 		Dimensions: make([]int, rank),
 	}
 
-	for axis := 0; axis < rank; axis++ {
+	for axis := range rank {
 		start, limit, stride := starts[axis], limits[axis], strides[axis]
 		dimSize := operand.Dimensions[axis]
 
@@ -1170,7 +1170,7 @@ func ReduceWindow(inputs, initialValues []shapes.Shape, reductionInputs, reducti
 	// Each output dimension is calculated orthogonally to the others.
 	outputDims := make([]int, rank)
 	operand := inputs[0]
-	for i := 0; i < rank; i++ {
+	for i := range rank {
 		inputDim := operand.Dimensions[i]
 		windowDim := windowDimensions[i]
 		if windowDim < 1 {
@@ -1550,10 +1550,10 @@ func DotGeneral(
 	// Check that all sizes are positive or dynamic (negative for dynamic dimensions is allowed)
 	// Note: Sizes can be negative when dimensions are dynamic. We only validate that non-dynamic sizes are positive.
 	// The actual validation happens at runtime when concrete dimensions are known.
-	_ = batchSize      // May be negative (dynamic), validated at runtime
-	_ = lhsCrossSize   // May be negative (dynamic), validated at runtime
+	_ = batchSize       // May be negative (dynamic), validated at runtime
+	_ = lhsCrossSize    // May be negative (dynamic), validated at runtime
 	_ = contractingSize // May be negative (dynamic), validated at runtime
-	_ = rhsCrossSize   // May be negative (dynamic), validated at runtime
+	_ = rhsCrossSize    // May be negative (dynamic), validated at runtime
 
 	// Reshape result to recover batch and cross dimensions.
 	resultingDims := make([]int, 0, len(batchDims)+len(lhsCrossDims)+len(rhsCrossDims))

pkg/installer/cpu.go

@@ -50,8 +50,8 @@ func detectGlibcVersion() (major int, minor int, err error) {
 	if lddErr != nil {
 		return 0, 0, errors.Wrap(lddErr, "failed to run ldd --version")
 	}
-	lines := strings.Split(string(lddBytes), "\n")
-	for _, line := range lines {
+	lines := strings.SplitSeq(string(lddBytes), "\n")
+	for line := range lines {
 		matches := glibcVersionRegex.FindStringSubmatch(line)
 		if len(matches) == 3 {
 			major, _ = strconv.Atoi(matches[1])

pkg/installer/pip.go

@@ -109,9 +109,9 @@ func (info *PipPackageInfo) ParseDependencies() ([]PipDependency, error) {
 
 			// Handle multiple comma-separated specifiers
 			// Example: "<10.0,>=9.8"
-			specParts := strings.Split(cleanSpec, ",")
+			specParts := strings.SplitSeq(cleanSpec, ",")
 
-			for _, part := range specParts {
+			for part := range specParts {
 				part = strings.TrimSpace(part)
 				if part == "" {
 					continue
@@ -192,7 +192,7 @@ func PipCompareVersion(v1, v2 string) int {
 	minLen := min(len(v1Parts), len(v2Parts))
 
 	// Compare common parts
-	for i := 0; i < minLen; i++ {
+	for i := range minLen {
 		var n1, n2 int
 		fmt.Sscanf(v1Parts[i], "%d", &n1)
 		fmt.Sscanf(v2Parts[i], "%d", &n2)
@@ -261,4 +261,3 @@ func PipPackageLinuxAMD64() *regexp.Regexp {
 func PipPackageLinuxAMD64Glibc231() *regexp.Regexp {
 	return pipPackageLinuxAMD64Glibc231
 }
-

pkg/stablehlo/value.go

@@ -3,6 +3,7 @@ package stablehlo
 import (
 	"fmt"
 	"io"
+	"strings"
 
 	"github.com/gomlx/go-xla/pkg/types/shapes"
 	"github.com/pkg/errors"
@@ -51,15 +52,15 @@ func (v *Value) String() string {
 // ConvertToValidName replaces any characters not in { "0"-"9", "a"-"z", "A-Z", "_" } to a "_",
 // making it a valid name for values and function arguments.
 func ConvertToValidName(name string) string {
-	var result string
+	var result strings.Builder
 	for _, c := range name {
 		if (c >= '0' && c <= '9') || (c >= 'a' && c <= 'z') || (c >= 'A' && c <= 'Z') || c == '_' {
-			result += string(c)
+			result.WriteString(string(c))
 		} else {
-			result += "_"
+			result.WriteString("_")
 		}
 	}
-	return result
+	return result.String()
 }
 
 // WithQuantization sets the quantization parameters for this value.

pkg/types/shapes/dtype.go

@@ -125,10 +125,10 @@ func UnsafeSliceForDType(dtype dtypes.DType, unsafePtr unsafe.Pointer, len int)
 
 // Pre-generate constant reflect.TypeOf for convenience.
 var (
-	float32Type  = reflect.TypeOf(float32(0))
-	float64Type  = reflect.TypeOf(float64(0))
-	float16Type  = reflect.TypeOf(float16.Float16(0))
-	bfloat16Type = reflect.TypeOf(bfloat16.BFloat16(0))
+	float32Type  = reflect.TypeFor[float32]()
+	float64Type  = reflect.TypeFor[float64]()
+	float16Type  = reflect.TypeFor[float16.Float16]()
+	bfloat16Type = reflect.TypeFor[bfloat16.BFloat16]()
 )
 
 // CastAsDType casts a numeric value to the corresponding for the DType.

pkg/types/shapes/shape.go

@@ -182,12 +182,7 @@ func (s Shape) Size() (size int) {
 //
 // Notice scalars are not zero in size -- they have size one, but rank zero.
 func (s Shape) IsZeroSize() bool {
-	for _, d := range s.Dimensions {
-		if d == 0 {
-			return true
-		}
-	}
-	return false
+	return slices.Contains(s.Dimensions, 0)
 
 }