Moved supressLogging to posix version only.

Author: janpfeifer

pkg/pjrt/dynamiclib_base.go

@@ -30,7 +30,6 @@ import (
 	"slices"
 	"strings"
 	"sync"
-	"syscall"
 
 	"github.com/pkg/errors"
 	"k8s.io/klog/v2"
@@ -262,21 +261,6 @@ func checkPlugin(name, pluginPath string) (err error) {
 	return
 }
 
-func suppressLogging() (newFd int, err error) {
-	newFd, err = syscall.Dup(2)
-	if err != nil {
-		err = errors.Wrap(err, "failed to duplicate (syscall.Dup) file descriptor 2 (stderr) in order to silence abseil logging")
-		return
-	}
-	err = syscall.Close(2)
-	if err != nil {
-		klog.Errorf("failed to syscall.Close(2): %v", err)
-		err = nil // Report, but continue.
-	}
-	os.Stderr = os.NewFile(uintptr(newFd), "stderr")
-	return
-}
-
 // FreeAll frees all plugins resources.
 // You should call this only if you are no longer going to use PJRT.
 // Useful for debugging memory leaks, this should release the plugins resources -- for these cases

pkg/pjrt/dynamiclib_posix.go

@@ -244,3 +244,18 @@ func SuppressAbseilLoggingHack(fn func()) {
 
 	fn()
 }
+
+func suppressLogging() (newFd int, err error) {
+	newFd, err = syscall.Dup(2)
+	if err != nil {
+		err = errors.Wrap(err, "failed to duplicate (syscall.Dup) file descriptor 2 (stderr) in order to silence abseil logging")
+		return
+	}
+	err = syscall.Close(2)
+	if err != nil {
+		klog.Errorf("failed to syscall.Close(2): %v", err)
+		err = nil // Report, but continue.
+	}
+	os.Stderr = os.NewFile(uintptr(newFd), "stderr")
+	return
+}