Removed debugging messages;

Replace path.IsAbs() by filepath.IsAbs().

Author: janpfeifer

internal/cmd/copy_go_code/main.go

@@ -4,12 +4,14 @@ import (
 	"bytes"
 	"flag"
 	"fmt"
-	"github.com/gomlx/go-xla/internal/must"
 	"io"
 	"os"
 	"path"
+	"path/filepath"
 	"regexp"
 	"strings"
+
+	"github.com/gomlx/go-xla/internal/must"
 )
 
 var (
@@ -47,7 +49,7 @@ func main() {
 
 	// Find the original file
 	originalPath := *flagOriginalGoFile
-	if !path.IsAbs(originalPath) {
+	if !filepath.IsAbs(originalPath) {
 		currentPath := must.M1(os.Getwd())
 		for {
 			originalPath = path.Join(currentPath, *flagOriginalGoFile)

pkg/pjrt/dynamiclib_base.go

@@ -23,9 +23,7 @@ package pjrt
 */
 import "C"
 import (
-	"fmt"
 	"os"
-	"path"
 	"path/filepath"
 	"regexp"
 	"slices"
@@ -94,7 +92,7 @@ func loadNamedPlugin(name string) (*Plugin, error) {
 	if plugin, found := loadedPlugins[name]; found {
 		return plugin, nil
 	}
-	if path.IsAbs(name) {
+	if filepath.IsAbs(name) {
 		for _, plugin := range loadedPlugins {
 			if plugin.Path() == name {
 				return plugin, nil
@@ -104,7 +102,7 @@ func loadNamedPlugin(name string) (*Plugin, error) {
 
 	// Search path to plugin -- except if name is an absolute path.
 	pluginPath := name
-	if !path.IsAbs(pluginPath) {
+	if !filepath.IsAbs(pluginPath) {
 		var found bool
 		pluginPath, found = searchPlugin(name)
 		if !found {
@@ -190,7 +188,6 @@ func searchPlugins(searchName string) (pluginsPaths map[string]string) {
 	}
 
 	// Search for plugins in other paths.
-	fmt.Printf("- Searching for plugin %q:\n", searchName)
 	for _, pluginPath := range pluginSearchPaths {
 		for _, pattern := range []string{
 			"pjrt-plugin-*.so", "pjrt_plugin_*.so", "pjrt_c_api_*_plugin.so",
@@ -202,22 +199,18 @@ func searchPlugins(searchName string) (pluginsPaths map[string]string) {
 			}
 			for _, candidate := range candidates {
 				name := pathToPluginName(candidate)
-				fmt.Printf("\t - Evaluating plugin candidate %q: named %q\n", candidate, name)
 				if name == "" {
 					continue
 				}
 				if searchName != "" && searchName != name {
-					fmt.Println("\t   (skipped, name doesn't match)")
 					continue
 				}
 				if _, found := pluginsPaths[name]; found {
 					// We already have a plugin with that name.
-					fmt.Println("\t   (skipped, plugin already loaded with that name)")
 					continue
 				}
 				err := checkPlugin(name, candidate)
 				if err != nil {
-					fmt.Println("\t   (skipped, plugin file didn't check)")
 					continue
 				}
 				pluginsPaths[name] = candidate

pkg/pjrt/dynamiclib_darwin.go

@@ -27,7 +27,6 @@ import "C"
 
 import (
 	"os"
-	"path"
 	"path/filepath"
 	"strings"
 	"syscall"
@@ -59,7 +58,7 @@ func osDefaultLibraryPaths() []string {
 	// Standard environment variables.
 	for _, varName := range []string{"DYLD_LIBRARY_PATH", "LD_LIBRARY_PATH"} {
 		for ldPath := range strings.SplitSeq(os.Getenv(varName), string(os.PathListSeparator)) {
-			if ldPath == "" || !path.IsAbs(ldPath) {
+			if ldPath == "" || !filepath.IsAbs(ldPath) {
 				// No empty or relative paths.
 				continue
 			}

pkg/pjrt/dynamiclib_posix.go

@@ -40,7 +40,6 @@ import "C"
 import (
 	"bufio"
 	"os"
-	"path"
 	"path/filepath"
 	"regexp"
 	"strings"
@@ -82,7 +81,7 @@ func osDefaultLibraryPaths() []string {
 
 	// Prefix LD_LIBRARY_PATH to non-absolute entries.
 	for ldPath := range strings.SplitSeq(os.Getenv("LD_LIBRARY_PATH"), ":") {
-		if ldPath == "" || !path.IsAbs(ldPath) {
+		if ldPath == "" || !filepath.IsAbs(ldPath) {
 			// No empty or relative paths.
 			continue
 		}

pkg/pjrt/plugins.go

@@ -125,7 +125,6 @@ func RegisterPreloadedPlugin(name string, api uintptr) error {
 // If it is not set it will search in `/usr/local/lib/gomlx` and the standard libraries directories of the
 // system (in linux in LD_LIBRARY_CONFIG and /etc/ld.so.conf file).
 func GetPlugin(name string) (*Plugin, error) {
-	fmt.Printf("GetPlugin(%q):\n", name)
 	return loadNamedPlugin(name)
 }