[BUG] Favourite tab call adds auto prefix even if set blank

[anbe108]

Favourties tab call adds auto prefix even if set blank on config
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

1. In config set nationalPrefix and regionalPrefix blank or by default disable it.
2. From Gonnect initate call to any number without prefix. call goes through.
3. Add that number to favourites.
4. Now initiate a call to that number from favourites tab - right click - call.

Expected behavior
The call should go to lets say 12345678@sipserver.

What Happens Instead

• If the number is lets say 12345678 > It goes to add +12345678@sipserver instead of 12345678@sipserver.
• If the number is lets say 012345678 > It goes to add germany prefix automatically ie +4912345678@sipserver

Screenshots or Logs

- Note all calls declined (the duration of 3sec that shows says invalid number from sip side)

Environment (please complete the following information):

• OS: Ubuntu 24.04.3 LTS
• Version 2.0.8 flathub flatpak
• Other Apps: Contacts not setup

Additional context
I rechecked this by altering configs to set the international code flags

[generic]
nationalPrefix=
regionalPrefix=

I checked the database callhistory.db in the table contactFlags the isFavorite flag is on to that normal number ie w/o prefix. But can't seem to find the code logic which may have caused it. It may be config issue also.

My sip provider (a local ISP) needs to dial phone numbers as this kind of 01234567899 format but they show incoming as 1234567899 from the same number. They dont support any prefixes. So far, can't seem to find a way to dial conveniently. Is there a way to force custom prefix such as 0 either?

Gonnect still feels more integrated than linphone etc. Highly appreciate your work ♥️. Thanks.

[Mik-]

I think we already fixed this with this commit. So the resolution will take place in the next release. But we need to double check.

[Mik-]

@anbe108 Thank you for your bug report.

There are some number portings in place, which are tailored to our company. This is fixed with the mentioned commit and the next release.

But there are also things regarding the *Prefix settings which work for us and obviously not for you. The *Prefix settings are only take into account for searching the phone books for the according contact and did not change the number, which is dialed. We need to rework this.

Regarding the constant prefix of a 0: I don't know how to handle this by now. We need to investigate more. Can you explain more, how this should work for you. I know of about to dial a 0 to get a trunc line. Is this of this kind?

[anbe108]

Can you explain more, how this should work for you. I know of about to dial a 0 to get a trunc line. Is this of this kind?

Thanks @Mik- . Not trunk. The prefix thing should work like following.

• For example: I receive a call from 1234561231.
• The sip server in my case shows this number , sometimes exactly the same 1234561231, or adds country prefix w/o + to make it 911234561231. (+91 is India national prefix) . Maybe some operator specific choice my ISP make.
• In order to dial that number from my side from log or contact, I need to add 0 w/o countryPrefix and dial as 01234561231 otherwise the call would not go through.
• In simple terms 1234561231 is the actual number. But I need to dial with 0 preceding. But ISP may show it as they choose.

So if there was a convenient way to do this through regex. I looked a little into the code base of the commit . That pre_search_replacer config if extended to suit dialing behavior globally would solve it immediately.

eg. I can do here incoming calls from the logs or contacts can go through something like pre_dial_replacer and everything should work in theory.

# for 10 digit incoming calls
[pre_dial_replacer0]
in=^(\\d{10})$
out=0\\1

• And then you can either log it in the Call Log as the original 1234561231 or the operator set choice.

Of course this is a SIP server specific problem, i believe they have 0 for outgoing and they does their internal routing; some smaller numbers/helplines don't require adding 0 on my local ISP. Something like the above implementation would make things very convenient.

I am quite illiterate in c++ otherwise I would have tried my hand at this.
Whats your take on this?
Thanks ♥️

Edit:
This is a difficult scenario. From what I understand the nationalPrefix flag adds a prefix regardless. So in theory pre_dial_replacer would have to override the nationalPrefix or a switch to disable it optionally. Would update further thoughts on this. Let me know your opinion.

[Mik-]

As this is quite complex, I need to investigate more and I will come back with more information.

[Mik-]

@anbe108 we are going to release a new version in the next one or two weeks. Therefore there is a beta version with the upcoming changes. This should fix the + and +49 problem.

If you like, you can test it out:

flatpak remote-add --if-not-exists flathub-beta https://flathub.org/beta-repo/flathub-beta.flatpakrepo
flatpak install flathub-beta de.gonicus.gonnect

[anbe108]

Sure. the + problems seems gone. Any ideas on the pre_dial_replacer proposal?