fix: handle PREF_DECODE_AS_RANGE in wg_set_pref

* set pref failing for sip and diameter

* empty commit

* c-ares seems to be 404

* fix: handle PREF_DECODE_AS_RANGE in wg_set_pref

---------

Co-authored-by: Osama Khalid <[email protected]>

Author: dipeshwalia

lib/Makefile

@@ -73,7 +73,7 @@ clean: mostlyclean
 # CARES
 #
 CARES_VERSION := 1.15.0
-CARES_URL := https://c-ares.org/download/c-ares-$(CARES_VERSION).tar.gz
+CARES_URL := https://github.com/c-ares/c-ares/releases/download/cares-$(subst .,_,$(CARES_VERSION))/c-ares-$(CARES_VERSION).tar.gz
 CARES_CHECKSUM := a1de6c5e7e1a6a13c926aae690e83d5caa51e7313d63da1cf2af6bc757c41d585aad5466bc3ba7b7f7793cb1748fa589f40972b196728851c8b059cfc8c3be50
 
 $(TARBALLS)/c-ares-$(CARES_VERSION).tar.gz:

lib/wiregasm/wiregasm.cpp

@@ -309,6 +309,45 @@ SetPrefResponse wg_set_pref(string module_name, string pref_name, string value)
 {
   SetPrefResponse res;
 
+  module_t *mod = prefs_find_module(module_name.c_str());
+  pref_t *p = prefs_find_preference(mod, pref_name.c_str());
+
+  if (p == NULL)
+  {
+    res.code = -1;
+    res.error = "Preference not found";
+    return res;
+  }
+
+  int type = prefs_get_type(p);
+
+  // handle decode as range ourselves
+  if (type == PREF_DECODE_AS_RANGE) {
+    range_t *new_range = NULL;
+    convert_ret_t ret = range_convert_str(NULL, &new_range, value.c_str(), prefs_get_max_value(p));
+
+    if (ret != CVT_NO_ERROR) {
+      res.code = -1;
+      res.error = "Invalid range";
+      return res;
+    }
+
+    if (prefs_set_range_value(p, new_range, pref_stashed)) {
+      pref_unstash_data_t unstashed_data;
+
+      unstashed_data.module = mod;
+      unstashed_data.handle_decode_as = true;
+
+      pref_unstash(p, &unstashed_data);
+      prefs_apply(mod);
+    }
+
+    res.code = 0;
+    return res;
+  }
+
+  // use prefs_set_pref for all other types for now
+
   char pref[4096];
   prefs_set_pref_e ret;
   char *errmsg = NULL;

samples/diameter_non_standard.pcap

@@ -271,6 +271,47 @@ describe("Wiregasm Library - Set Preferences", () => {
     expect(pref2.type).toBe(PrefType.PREF_DECODE_AS_RANGE);
     expect(pref2.range_value).toBe("8001");
   });
+
+  test("set preferences works for diameter", async () => {
+    
+    const pref = wg.get_pref("diameter", "tcp.port");
+    expect(pref.type).toBe(PrefType.PREF_DECODE_AS_RANGE);
+    expect(pref.range_value).toBe(
+      "3868"
+    );
+
+    wg.set_pref("diameter", "tcp.port", "3871");
+
+    const pref2 = wg.get_pref("diameter", "tcp.port");
+    expect(pref2.type).toBe(PrefType.PREF_DECODE_AS_RANGE);
+    expect(pref2.range_value).toBe("3871");
+
+    const data = await fs.readFile("samples/diameter_non_standard.pcap");
+    const ret = wg.load("diameter_non_standard.pcap", data);
+
+    expect(ret.code).toEqual(0);
+
+    const frame = wg.frame(1);
+    const last_tree = frame.tree.get(frame.tree.size() - 1);
+
+    expect(last_tree.label).toBe("Diameter Protocol");
+  });
+
+  test("set preferences works for sip", async () => {
+    const pref = wg.get_pref("sip", "tcp.port");
+    expect(pref.type).toBe(PrefType.PREF_DECODE_AS_RANGE);
+    expect(pref.range_value).toBe(
+      "5060"
+    );
+
+    wg.set_pref("sip", "tcp.port", "8001");
+
+    const pref2 = wg.get_pref("sip", "tcp.port");
+    expect(pref2.type).toBe(PrefType.PREF_DECODE_AS_RANGE);
+    expect(pref2.range_value).toBe("8001");
+  });
+
+
 });
 
 describe("Wiregasm Library - nghttp2", () => {