Skip to content

Commit f9165b1

Browse files
committed
replace continue-on-error with fail-fast
1 parent 191389b commit f9165b1

File tree

5 files changed

+5
-3
lines changed

5 files changed

+5
-3
lines changed

.github/workflows/bazel_cpu_rbe.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ jobs:
2626
# Explicitly set the shell to bash to override the default Windows environment, i.e, cmd.
2727
shell: bash
2828
strategy:
29+
fail-fast: false # don't cancel all jobs on failure
2930
matrix:
3031
runner: ["windows-x86-n2-64", "linux-x86-n2-16", "linux-arm64-t2a-16"]
3132

.github/workflows/build_artifacts.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,12 +130,12 @@ jobs:
130130
131131
build_artifacts:
132132
needs: determine_matrix
133-
continue-on-error: true
134133
defaults:
135134
run:
136135
# Explicitly set the shell to bash to override the default Windows environment, i.e, cmd.
137136
shell: bash
138137
strategy:
138+
fail-fast: false # don't cancel all jobs on failure
139139
matrix:
140140
runner: ${{ fromJSON(needs.determine_matrix.outputs.platform_matrix) }}
141141
artifact: ${{ fromJSON(needs.determine_matrix.outputs.artifact_matrix) }}

.github/workflows/pytest_cpu.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ jobs:
3333
run_pytest:
3434
name: "Run CPU tests with Pytest"
3535
needs: build_jaxlib_artifact
36-
continue-on-error: true
3736
defaults:
3837
run:
3938
# Explicitly set the shell to bash to override the default Windows environment, i.e, cmd.
4039
shell: bash
4140
strategy:
41+
fail-fast: false # don't cancel all jobs on failure
4242
matrix:
4343
runner: ["linux-x86-n2-64", "linux-arm64-t2a-48", "windows-x86-n2-64"]
4444
python: ["3.10", "3.11", "3.12", "3.13"]

.github/workflows/pytest_gpu.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@ jobs:
3434
run_tests:
3535
needs: build_artifacts
3636
strategy:
37+
fail-fast: false # don't cancel all jobs on failure
3738
matrix:
3839
test_env: [
3940
{cuda_version: "12.3", runner: "linux-x86-g2-48-l4-4gpu",

.github/workflows/pytest_tpu.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ concurrency:
2222
jobs:
2323
run_tpu_tests:
2424
strategy:
25-
fail-fast: false
25+
fail-fast: false # don't cancel all jobs on failure
2626
matrix:
2727
jaxlib-version: ["pypi_latest", "nightly", "nightly+oldest_supported_libtpu"]
2828
tpu: [

0 commit comments

Comments
 (0)