Fix a bug where we are not removing TPU requests from the main container correctly (#43)

quoctruong · web-flow · commit 431c2a11f99e · 2025-10-16T16:06:59.000-07:00
* Fix bug with TPU request

* Fix formatting
diff --git a/packages/k8s/src/hooks/prepare-job.ts b/packages/k8s/src/hooks/prepare-job.ts
@@ -164,10 +164,13 @@ export function processServiceContainers(
     )
   })
 
-  const tpuRequestingContainers = services.filter(
+  const tpuRequestingContainers = serviceContainers.filter(
     service =>
       service.resources?.limits && service.resources.limits['google.com/tpu']
   )
+  core.debug(
+    `There are ${tpuRequestingContainers.length} service container requesting for TPU's.`
+  )
 
   if (tpuRequestingContainers.length > 1) {
     throw new Error(

Original file line number	Diff line number	Diff line change
`@@ -164,10 +164,13 @@ export function processServiceContainers(`
`164`	`164`	`)`
`165`	`165`	`})`
`166`	`166`
`167`		`- const tpuRequestingContainers = services.filter(`
	`167`	`+ const tpuRequestingContainers = serviceContainers.filter(`
`168`	`168`	`service =>`
`169`	`169`	`service.resources?.limits && service.resources.limits['google.com/tpu']`
`170`	`170`	`)`
	`171`	`+ core.debug(`
	`172`	+ `There are ${tpuRequestingContainers.length} service container requesting for TPU's.`
	`173`	`+ )`
`171`	`174`
`172`	`175`	`if (tpuRequestingContainers.length > 1) {`
`173`	`176`	`throw new Error(`