Skip to content

Commit 04f0ae1

Browse files
OpenFst Teamagutkin
authored andcommitted
Make LogWeight and TropicalWeight constructor explicit
PiperOrigin-RevId: 878602351
1 parent e1df17b commit 04f0ae1

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

openfst/lib/float-weight.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -210,8 +210,7 @@ class TropicalWeightTpl : public FloatWeightTpl<T> {
210210

211211
TropicalWeightTpl() noexcept : FloatWeightTpl<T>() {}
212212

213-
// TODO: Enable "explicit" when dependent code is resolved.
214-
/* explicit */ constexpr TropicalWeightTpl(T f) : FloatWeightTpl<T>(f) {}
213+
explicit constexpr TropicalWeightTpl(T f) : FloatWeightTpl<T>(f) {}
215214

216215
static constexpr TropicalWeightTpl<T> Zero() {
217216
return TropicalWeightTpl<T>(Limits::PosInfinity());
@@ -434,8 +433,7 @@ class LogWeightTpl : public FloatWeightTpl<T> {
434433

435434
LogWeightTpl() noexcept : FloatWeightTpl<T>() {}
436435

437-
// TODO: Add explicit when nlp/grm/sfst is updated.
438-
/* explicit */ constexpr LogWeightTpl(T f) : FloatWeightTpl<T>(f) {}
436+
explicit constexpr LogWeightTpl(T f) : FloatWeightTpl<T>(f) {}
439437

440438
static constexpr LogWeightTpl Zero() {
441439
return LogWeightTpl(Limits::PosInfinity());

0 commit comments

Comments
 (0)