Fix mismatched use of xnn_allocate_zero_simd_memory and xnn_release_memory

dsharletg · xnnpack-bot · commit 4e06318b61a9 · 2025-02-18T23:32:13.000-08:00
This causes crashes on windows, uncovered in #7830. This bug appears with `xnn_create_runtime_v4`, other paths that allocate workspaces have matching allocate/free calls. PiperOrigin-RevId: 728501674
diff --git a/src/runtime.c b/src/runtime.c
@@ -532,7 +532,7 @@ enum xnn_status xnn_create_runtime_v4(
 
   if (workspace == NULL) {
     xnn_log_debug("Allocating non-shared workspace");
-    workspace = xnn_allocate_zero_simd_memory(sizeof(struct xnn_workspace));
+    workspace = xnn_allocate_zero_memory(sizeof(struct xnn_workspace));
   }
 
   const uint32_t optimization_flags = XNN_FLAG_HINT_SPARSE_INFERENCE | XNN_FLAG_HINT_FP16_INFERENCE |

Original file line number	Diff line number	Diff line change
`@@ -532,7 +532,7 @@ enum xnn_status xnn_create_runtime_v4(`
`532`	`532`
`533`	`533`	`if (workspace == NULL) {`
`534`	`534`	`xnn_log_debug("Allocating non-shared workspace");`
`535`		`- workspace = xnn_allocate_zero_simd_memory(sizeof(struct xnn_workspace));`
	`535`	`+ workspace = xnn_allocate_zero_memory(sizeof(struct xnn_workspace));`
`536`	`536`	`}`
`537`	`537`
`538`	`538`	`const uint32_t optimization_flags = XNN_FLAG_HINT_SPARSE_INFERENCE \| XNN_FLAG_HINT_FP16_INFERENCE \|`