skip logic on the form not clearing when different options are selected

[aurangzaibumer]

Describe the bug
When we apply the skip logic, the answer is retaining the previously given answer instead of having a default value.
For any question trees that have to skip logic applied, if the child questions have answers, they remain visible, even if the original question or “parent” question is no longer displayed.

To Reproduce
Steps to reproduce the behavior:
Having enableWhen/Skip logic question, For suppose if you have Question B that depends on Question A (skip logic), if Question A is set as Yes, Question B appears and you select an answer. Then you re-select Question A to NO, Question B disappears and when you re-select Question A to Yes again, Question B appears with a pre-selected answer that was selected before.

Expected behavior
To control if we want to have answers already selected (if reset) or not for skip logic questions.

Screenshots
https://user-images.githubusercontent.com/35099184/216338902-b1528f85-d575-489b-b209-8627582503a4.mp4

[aditya-07]

@aurangzaibumer Could you please add the Questionnaire here. Thanks!

[aurangzaibumer]

@aurangzaibumer Could you please add the Questionnaire here. Thanks!

`

{
  "title": "eCBIS new Patient Creation Confirmation ",
  "version": "0.0.1",
  "id": "f0a04fc4-4179-4df4-b2dc-8b2eac444d0b",
  "description": "eCBIS new Patient Creation Confirmation ",
  "resourceType": "Questionnaire",
  "language": "en-GB",
  "status": "active",
  "publisher": "ONA",
  "date": "2022-08-14T00:00:00Z",
  "meta": {
    "profile": [
      "http://ehelse.no/fhir/StructureDefinition/sdf-Questionnaire"
    ],
    "tag": [
      {
        "system": "urn:ietf:bcp:47",
        "code": "en-GB",
        "display": "English"
      }
    ]
  },
  "useContext": [
    {
      "code": {
        "system": "http://hl7.org/fhir/ValueSet/usage-context-type",
        "code": "focus",
        "display": "Clinical Focus"
      },
      "valueCodeableConcept": {
        "coding": [
          {
            "system": "urn:oid:2.16.578.1.12.4.1.1.8655",
            "display": "eCBIS new Patient Creation Confirmation "
          }
        ]
      }
    }
  ],
  "contact": [
    {
      "name": "https://www.ona.1o"
    }
  ],
  "subjectType": [
    "Patient"
  ],
  "extension": [
    {
      "url": "http://helsenorge.no/fhir/StructureDefinition/sdf-information-message",
      "valueCoding": {
        "system": "http://helsenorge.no/fhir/ValueSet/sdf-information-message",
        "code": "1"
      }
    }
  ],
  "item": [
    {
      "linkId": "d597ac8a-dcab-405e-c31b-c50f97dcb319",
      "type": "choice",
      "text": "Have you registered the new family member?",
      "required": true,
      "answerOption": [
        {
          "valueCoding": {
            "id": "08841a7b-99fd-49df-9d0d-30df5164f2d8",
            "code": "yes",
            "system": "urn:uuid:37d42f58-0929-4ce8-f9d8-752da15a3bfc",
            "display": "Yes"
          }
        },
        {
          "valueCoding": {
            "id": "81918451-a7ed-4f00-c5e9-ed917f0a9893",
            "code": "no",
            "system": "urn:uuid:37d42f58-0929-4ce8-f9d8-752da15a3bfc",
            "display": "No"
          }
        }
      ]
    },
    {
      "linkId": "03e3b3d1-b1a4-4162-a4eb-57c5df4c52da",
      "type": "text",
      "text": "Please add the Family member IDs",
      "required": true,
      "enableWhen": [
        {
          "question": "d597ac8a-dcab-405e-c31b-c50f97dcb319",
          "operator": "=",
          "answerCoding": {
            "system": "urn:uuid:37d42f58-0929-4ce8-f9d8-752da15a3bfc",
            "code": "yes"
          }
        }
      ]
    },
    {
      "linkId": "cf0093a9-1e38-422b-fc81-273caa0bb48a",
      "type": "choice",
      "text": "Child has a cough?",
      "required": true,
      "answerOption": [
        {
          "valueCoding": {
            "id": "eb976bac-c680-423b-cdd5-9740ac8268d4",
            "code": "yes",
            "system": "urn:uuid:d3051c21-8668-412e-a2dd-105cf274b260",
            "display": "Yes"
          }
        },
        {
          "valueCoding": {
            "id": "8f8cf0b9-0043-4b9f-8ac6-50668e6ee1a1",
            "code": "no",
            "system": "urn:uuid:d3051c21-8668-412e-a2dd-105cf274b260",
            "display": "No"
          }
        }
      ],
      "extension": [
        {
          "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
          "valueCodeableConcept": {
            "coding": [
              {
                "system": "http://hl7.org/fhir/ValueSet/questionnaire-item-control",
                "code": "radio-button"
              }
            ]
          }
        }
      ]
    },
    {
      "linkId": "3ebb1e6d-237d-4b1e-edf3-dda25cb53891",
      "type": "choice",
      "required": true,
      "answerOption": [
        {
          "valueCoding": {
            "id": "b368c2a6-6b72-462c-ca29-40650c06fe37",
            "code": "1---13-days",
            "system": "urn:uuid:7690c680-5247-457e-d68f-d65f5b40d6c7",
            "display": "1 - 13 days"
          }
        },
        {
          "valueCoding": {
            "id": "a778cf91-7361-4392-8493-81affbf4a753",
            "code": "14+-days",
            "system": "urn:uuid:7690c680-5247-457e-d68f-d65f5b40d6c7",
            "display": "14+ days"
          }
        }
      ],
      "text": "How many days child coughing?",
      "enableWhen": [
        {
          "question": "cf0093a9-1e38-422b-fc81-273caa0bb48a",
          "operator": "=",
          "answerCoding": {
            "system": "urn:uuid:d3051c21-8668-412e-a2dd-105cf274b260",
            "code": "yes"
          }
        }
      ],
      "enableBehavior": "any",
      "extension": [
        {
          "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
          "valueCodeableConcept": {
            "coding": [
              {
                "system": "http://hl7.org/fhir/ValueSet/questionnaire-item-control",
                "code": "radio-button"
              }
            ]
          }
        }
      ]
    },
    {
      "linkId": "94357450-e603-49f7-899c-464ecd10ddd1",
      "type": "choice",
      "required": true,
      "answerOption": [
        {
          "valueCoding": {
            "id": "c5fa47f7-0683-4169-8f9d-81b7e5f0e68b",
            "code": "yes",
            "system": "urn:uuid:4ae66618-142d-4e2c-dd66-5d63c14b83a9",
            "display": "Yes"
          }
        },
        {
          "valueCoding": {
            "id": "e55a53f6-f763-4893-8313-e9ac7a1b8037",
            "code": "no",
            "system": "urn:uuid:4ae66618-142d-4e2c-dd66-5d63c14b83a9",
            "display": "No"
          }
        }
      ],
      "text": "Child has a running stomach?",
      "extension": [
        {
          "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
          "valueCodeableConcept": {
            "coding": [
              {
                "system": "http://hl7.org/fhir/ValueSet/questionnaire-item-control",
                "code": "radio-button"
              }
            ]
          }
        }
      ]
    },
    {
      "linkId": "9eaaeb53-7dc1-4b15-8f58-8e8bfa0f94d3",
      "type": "choice",
      "required": true,
      "answerOption": [
        {
          "valueCoding": {
            "id": "f348a6ff-5a6e-4baf-bde1-90fff5a468f3",
            "code": "1---13-days",
            "system": "urn:uuid:0e200006-e660-4bae-8667-cb55aac784aa",
            "display": "1 - 13 days"
          }
        },
        {
          "valueCoding": {
            "id": "7b1736e1-2802-43ed-cfae-4f1c055c38b1",
            "code": "14+-days",
            "system": "urn:uuid:0e200006-e660-4bae-8667-cb55aac784aa",
            "display": "14+ days"
          }
        }
      ],
      "text": "How many days child has running stomach?",
      "enableWhen": [
        {
          "question": "94357450-e603-49f7-899c-464ecd10ddd1",
          "operator": "=",
          "answerCoding": {
            "system": "urn:uuid:4ae66618-142d-4e2c-dd66-5d63c14b83a9",
            "code": "yes"
          }
        }
      ],
      "enableBehavior": "any",
      "extension": [
        {
          "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
          "valueCodeableConcept": {
            "coding": [
              {
                "system": "http://hl7.org/fhir/ValueSet/questionnaire-item-control",
                "code": "radio-button"
              }
            ]
          }
        }
      ]
    },
    {
      "linkId": "14648d8c-c88f-40be-9f25-66d7ba621482",
      "type": "choice",
      "required": true,
      "answerOption": [
        {
          "valueCoding": {
            "id": "d72302da-e416-4c81-8994-a9102d11b10c",
            "code": "yes",
            "system": "urn:uuid:08516020-d926-4463-863e-d6f45b0d317b",
            "display": "Yes"
          }
        },
        {
          "valueCoding": {
            "id": "cd363c0f-ca7c-4f78-976c-88f091d88c4e",
            "code": "no",
            "system": "urn:uuid:08516020-d926-4463-863e-d6f45b0d317b",
            "display": "No"
          }
        }
      ],
      "text": "Child has fever?",
      "extension": [
        {
          "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
          "valueCodeableConcept": {
            "coding": [
              {
                "system": "http://hl7.org/fhir/ValueSet/questionnaire-item-control",
                "code": "radio-button"
              }
            ]
          }
        }
      ]
    },
    {
      "linkId": "96cd56d0-b7e1-437e-8354-26cddaf0f0b6",
      "type": "choice",
      "required": true,
      "answerOption": [
        {
          "valueCoding": {
            "id": "1cd68bb3-a1a6-4ec4-87d6-123225fe4bc1",
            "code": "1---6-days",
            "system": "urn:uuid:8173c8c3-d594-4510-8f91-980e96216291",
            "display": "1 - 6 days"
          }
        },
        {
          "valueCoding": {
            "id": "2f795e93-1efd-4208-8f06-a0581985ebac",
            "code": "7+-days",
            "system": "urn:uuid:8173c8c3-d594-4510-8f91-980e96216291",
            "display": "7+ days"
          }
        }
      ],
      "text": "How many days child has a fever?",
      "enableWhen": [
        {
          "question": "14648d8c-c88f-40be-9f25-66d7ba621482",
          "operator": "=",
          "answerCoding": {
            "system": "urn:uuid:08516020-d926-4463-863e-d6f45b0d317b",
            "code": "yes"
          }
        }
      ],
      "enableBehavior": "any",
      "extension": [
        {
          "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
          "valueCodeableConcept": {
            "coding": [
              {
                "system": "http://hl7.org/fhir/ValueSet/questionnaire-item-control",
                "code": "radio-button"
              }
            ]
          }
        }
      ]
    },
    {
      "linkId": "60e8812f-9741-4fb0-8e9e-035b860f42b5",
      "type": "choice",
      "text": "Child has symptoms other than cough, runing stomach, or fever? ",
      "required": true,
      "answerOption": [
        {
          "valueCoding": {
            "id": "bf7adff1-e7ab-43d5-dccd-f088a88fed4f",
            "code": "yes",
            "system": "urn:uuid:77130d5d-c082-4dc1-8e75-6468596a8fe0",
            "display": "Yes"
          }
        },
        {
          "valueCoding": {
            "id": "ab1f5b67-0616-4ff9-9594-28f96d9bb2ff",
            "code": "no",
            "system": "urn:uuid:77130d5d-c082-4dc1-8e75-6468596a8fe0",
            "display": "No"
          }
        }
      ],
      "enableWhen": [
        {
          "question": "cf0093a9-1e38-422b-fc81-273caa0bb48a",
          "operator": "=",
          "answerCoding": {
            "system": "urn:uuid:d3051c21-8668-412e-a2dd-105cf274b260",
            "code": "no"
          }
        },
        {
          "question": "94357450-e603-49f7-899c-464ecd10ddd1",
          "operator": "=",
          "answerCoding": {
            "system": "urn:uuid:4ae66618-142d-4e2c-dd66-5d63c14b83a9",
            "code": "no"
          }
        },
        {
          "question": "14648d8c-c88f-40be-9f25-66d7ba621482",
          "operator": "=",
          "answerCoding": {
            "system": "urn:uuid:08516020-d926-4463-863e-d6f45b0d317b",
            "code": "no"
          }
        }
      ],
      "enableBehavior": "all",
      "extension": [
        {
          "url": "http://hl7.org/fhir/StructureDefinition/questionnaire-itemControl",
          "valueCodeableConcept": {
            "coding": [
              {
                "system": "http://hl7.org/fhir/ValueSet/questionnaire-item-control",
                "code": "radio-button"
              }
            ]
          }
        }
      ]
    }
  ]
}

`

[jingtang10]

@aditya-07

[jingtang10]

Thanks @aurangzaibumer for raising this. @aditya-07's work in a previous PR actually introduced this behaviour. It's not clear to me that we shouldn't be preserving the answers when questions are disabled and re-enabled. This could be very useful when the user accidentally disables a question whilst exploring the questionnaire.

Additionally, the disabled answers won't be included in the final questionnaire response - if that's what you were worried about!

@shelaghm @rowo @f-odhiambo @joiskash for visibility.

[jingtang10]

I'd like to hear more about the concerns with the current behaviour, and if we do need revisit the current behaviour.

If there's no major concern, we could close this.