Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including "rewrite_polyfills=false" in parameters to web service has no affect. #3777

Open
ScottHuston opened this issue Feb 28, 2021 · 2 comments
Labels
triage-done Has been reviewed by someone on triage rotation.

Comments

@ScottHuston
Copy link

ScottHuston commented Feb 28, 2021

When I POST a request to https://closure-compiler.appspot.com/compile with "rewrite_polyfills=false" included, it appears to be ignored.

["output_format=json", "compilation_level=SIMPLE_OPTIMIZATIONS", "language=ECMASCRIPT8", "rewrite_polyfills=false", "output_info=compiled_code", "output_info=statistics", "output_info=errors", "output_info=warnings", "code_url=https://<<removed>>"]

Same behavior when I try using the web page manually and add @rewrite_polyfills false

`
// ==ClosureCompiler==

// @compilation_level SIMPLE_OPTIMIZATIONS
// @output_file_name default.js
// @rewrite_polyfills false
// @code_url https://<>
// ==/ClosureCompiler==
`

Tellingly, in this case, the POST DATA tab doesn't show that parameter included.

Can we get this parameter supported in the web service?

@rishipal rishipal added the triage-done Has been reviewed by someone on triage rotation. label Mar 2, 2021
@rishipal
Copy link
Contributor

rishipal commented Mar 2, 2021

Hi, did the server not emit an error when it failed to process your request with that parameter?
As per https://developers.google.com/closure/compiler/docs/api-ref#params, we currently support a limited set of parameters in the API and if you supply other parameters, you should have seen this error.

The HTTP request contains a parameter other than one of the ones listed in this document.

@ScottHuston
Copy link
Author

No error was reported. Processed just fine, just didn't do what I asked.

Why not support this option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage-done Has been reviewed by someone on triage rotation.
Projects
None yet
Development

No branches or pull requests

2 participants