TemplateLiteralNode calculates its SoyType rather than requiring state be set on it.

PiperOrigin-RevId: 910452857

Author: Jesse-Good

java/src/com/google/template/soy/exprtree/TemplateLiteralNode.java

@@ -32,7 +32,6 @@ public final class TemplateLiteralNode extends AbstractParentExprNode {
 
   private TriState isStaticCall = TriState.UNSET;
   private String templateFqn;
-  private SoyType type;
 
   public static TemplateLiteralNode forVarRef(VarRefNode varRef) {
     return forVarRef(varRef, varRef.getSourceLocation());
@@ -55,7 +54,6 @@ private TemplateLiteralNode(TemplateLiteralNode orig, CopyState copyState) {
     super(orig, copyState);
     this.isStaticCall = orig.isStaticCall;
     this.templateFqn = orig.templateFqn;
-    this.type = orig.type;
   }
 
   /** Returns whether this node is the root expression of a CallNode. */
@@ -74,10 +72,8 @@ public void resolveTemplateName() {
     SoyType type = getChild(0).getType();
     if (type instanceof TemplateImportType) {
       templateFqn = ((TemplateImportType) type).getName();
-      this.type = type;
     } else {
       templateFqn = "";
-      this.type = UnknownType.getInstance();
     }
   }
 
@@ -93,12 +89,22 @@ public String getResolvedName() {
 
   @Override
   public SoyType getType() {
-    return type;
+    if (getChild(0) instanceof VarRefNode varRef) {
+      if (varRef.getDefnDecl() != null
+          && varRef.getDefnDecl().hasType()
+          && varRef.getDefnDecl().type() instanceof TemplateImportType templateType) {
+        SoyType type = templateType.getBasicTemplateType();
+        if (type != null) {
+          return type;
+        }
+      }
+    }
+    return UnknownType.getInstance();
   }
 
   @Override
   public void setType(SoyType type) {
-    this.type = Preconditions.checkNotNull(type);
+    throw new UnsupportedOperationException();
   }
 
   @Override

java/src/com/google/template/soy/passes/ResolveExpressionTypesPass.java

@@ -2738,21 +2738,18 @@ protected void visitTemplateLiteralNode(TemplateLiteralNode node) {
         errorReporter.report(
             node.getSourceLocation(), TEMPLATE_TYPE_PARAMETERS_CANNOT_USE_INFERRED_TYPES);
         // Placeholder type to prevent further confusing errors.
-        node.setType(UnknownType.getInstance());
         return;
       }
 
       visitChildren(node);
 
       SoyType existingType = node.getType();
-      if (existingType instanceof TemplateImportType templateImportType) {
-        TemplateType basicType = templateImportType.getBasicTemplateType();
-        node.setType(
-            Preconditions.checkNotNull(
-                basicType,
-                "No type for %s (%s)",
-                node.getResolvedName(),
-                node.getSourceLocation()));
+      if (existingType instanceof TemplateImportType) {
+        Preconditions.checkNotNull(
+            node.getType(),
+            "No type for %s (%s)",
+            node.getResolvedName(),
+            node.getSourceLocation());
       }
     }