Skip to content

Commit aed7b9e

Browse files
committed
Update appengine imports for external_testcase_reader. (drive by add additional component filter for extra safety)
1 parent 0f590af commit aed7b9e

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

src/clusterfuzz/_internal/cron/external_testcase_reader.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
from appengine.libs import form
2323
from appengine.libs import gcs
24-
from appengine.libs import helpers
24+
from clusterfuzz._internal.metrics import logs
2525
from clusterfuzz._internal.config import local_config
2626
from clusterfuzz._internal.issue_management.google_issue_tracker import \
2727
issue_tracker
@@ -158,18 +158,18 @@ def handle_testcases(tracker, config):
158158
# Handle bugs that were already submitted and still open.
159159
older_issues = tracker.find_issues_with_filters(
160160
keywords=[],
161-
query_filters=['componentid:1600865', 'status:accepted'],
161+
query_filters=['componentid:1600865', 'componentid:1457062+', 'status:accepted'],
162162
only_open=True)
163163
for issue in older_issues:
164164
# Close out older bugs that may have failed to reproduce.
165165
if close_issue_if_not_reproducible(issue, config):
166-
helpers.log('Closing issue {issue_id} as it failed to reproduce',
166+
logs.info('Closing issue {issue_id} as it failed to reproduce',
167167
issue.id)
168168

169169
# Handle new bugs that may need to be submitted.
170170
issues = tracker.find_issues_with_filters(
171171
keywords=[],
172-
query_filters=['componentid:1600865', 'status:new'],
172+
query_filters=['componentid:1600865', 'componentid:1457062+', 'status:new'],
173173
only_open=True)
174174
if len(issues) == 0:
175175
return
@@ -189,7 +189,7 @@ def handle_testcases(tracker, config):
189189
reporters_map[issue.reporter] = reporters_map.get(issue.reporter, 1) + 1
190190
if close_issue_if_invalid(issue, attachment_metadata, commandline_flags,
191191
vrp_uploaders):
192-
helpers.log('Closing issue {issue_id} as it is invalid', issue.id)
192+
logs.info('Closing issue {issue_id} as it is invalid', issue.id)
193193
continue
194194

195195
# Submit valid testcases.
@@ -202,7 +202,7 @@ def handle_testcases(tracker, config):
202202
issue.status = ISSUETRACKER_ACCEPTED_STATE
203203
issue.assignee = '[email protected]'
204204
issue.save(new_comment=comment_message, notify=True)
205-
helpers.log('Submitted testcase file for issue {issue_id}', issue.id)
205+
logs.info('Submitted testcase file for issue {issue_id}', issue.id)
206206

207207

208208
def main():

src/python/bot/startup/run_cron.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,11 @@ def main():
4848
'config', 'modules')
4949
if os.path.exists(config_modules_path):
5050
sys.path.append(config_modules_path)
51+
52+
if (task == 'external_testcase_reader'):
53+
appengine_path = os.path.join(root_directory, 'src', 'appengine')
54+
if os.path.exists(appengine_path):
55+
sys.path.append(appengine_path)
5156

5257
try:
5358
# Run any module initialization code.

0 commit comments

Comments
 (0)