Code Review Bot should act like a reviewer

[mbrukman]

Right now, Code Review Bot simply adds a comment but does not block submission of the PR, so folks have to be careful to not accidentally merge a PR prior to all checks being satisfied.

Instead, Code Review Bot should act more like a reviewer:

• add comments with "Request changes" bit set so that it blocks merging
• once all checks are satisfied, add a comment and release the block on merge by resolving own review

[su7edja]

Hi @mbrukman I came across your project and thought it was interesting. I'm new at Go and decided to play around with it a little.
I added the function to make a "request_changes" review in a PR: #36
I'm not sure what you mean by the second point in this issue about "all checks". Let me know if I can help with that. Thanks!

[mbrukman]

Hi @su7edja, thanks for the contribution! I'll provide some feedback on the PR itself.

What I mean by "once all checks are satisfied" is that the tool should automatically resolve its own review, so that a human doesn't have to manually "cancel" or "discard" the tool's feedback on a PR, it should be automatically handling it if a user comes back and fixes the issues in the PR (i.e., by signing the CLA, so that all the commits become compliant again).

For reference, right now, the tool just adds a [cla: no] label to the PR if it's non-compliant, but next time it looks at the PR, if it becomes compliant, the tool will remove the [cla: no] tag and add the [cla: yes] tag, thus showing everyone that the user resolved the issue.

Similarly, if the tool adds a [cla: yes] label initially, and then a user goes ahead and adds non-compliant commits to the same PR, next time, the tool will remove the [cla: yes] label and add the [cla: no] label, which alerts everyone that something has changed and the PR is no longer compliant.

Does that help clarify?