Skip to content

Commit c504b0e

Browse files
arpitjain099copybara-github
authored andcommitted
Copybara import of the project:
-- f071a05 by Arpit Jain <arpitjain099@gmail.com>: docs: fix seven typos in design and overview docs All caught by codespell on docs/, all in user-facing markdown (no code, identifier renames, or API names): docs/design/design.md filles -> files, diferent -> different, relevent -> relevant docs/design/thunks_...md sigatures -> signatures docs/overview/limits.md ohter -> other docs/overview/reference_safety.md succintly -> succinctly docs/overview/unstable_features.md intialization -> initialization False-positives in the same scan that I deliberately did NOT fix: re-declared / re-declare (both forms are valid), unparseable (both 'parseable' and 'parsable' forms are accepted), statics (a real C++ term). Signed-off-by: Arpit Jain <arpitjain099@gmail.com> FUTURE_COPYBARA_INTEGRATE_REVIEW=#1021 from arpitjain099:docs/typos f071a05 PiperOrigin-RevId: 914860013
1 parent ff391f8 commit c504b0e

6 files changed

Lines changed: 8 additions & 8 deletions

File tree

bazel/llvm.bzl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def _llvm_loader_repository(repository_ctx):
5353
executable = False,
5454
)
5555

56-
LLVM_COMMIT_SHA = "87d42c13cd6b119240781f31e5869981d500a186"
56+
LLVM_COMMIT_SHA = "eeca78019189a5559a694bb4774fec3e6ae07096"
5757

5858
def llvm_loader_repository_dependencies():
5959
# This *declares* the dependency, but it won't actually be *downloaded* unless it's used.

docs/design/design.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ language, as that provides the most natural way to define Rust APIs.
226226
C++ code.** When making changes to C++ code, engineers are less likely to
227227
notice and update the annotations in sidecar files.
228228
* Presubmits can catch some cases of desynchronization between C++ headers
229-
and sidecar filles. However, presubmit errors that remind engineers to
229+
and sidecar files. However, presubmit errors that remind engineers to
230230
edit more files create an inferior user experience.
231231
* **Sidecar files create extra friction to modify the code.** Where previously
232232
one had to edit only a C++ header and a C++ source file, now one also likely
@@ -377,7 +377,7 @@ the more library and team-specific interop customizations we will have to
377377
support, and the more it will make sense for the performance team to tweak
378378
generated code to implement sweeping optimizations. These kinds of changes
379379
should be readily possible, and they should not create conflicts of interest
380-
between diferent users of the interop tooling.
380+
between different users of the interop tooling.
381381

382382
### Interop tooling should facilitate C++ to Rust migration
383383

@@ -570,7 +570,7 @@ C++ headers for Rust libraries which expose a public C API**.
570570
generation is driven by the build system (i.e. by Bazel, or Cargo, or
571571
GN/ninja, rather than manually) and that the integration between the FFI
572572
tools and the build system doesn't have any bugs (e.g. that it
573-
faithfully replicates all relevent compilation flags).
573+
faithfully replicates all relevant compilation flags).
574574

575575
**Evaluation**
576576

docs/design/thunks_for_class_template_member_functions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ Cons:
109109
110110
- **Assumes a particular ABI** - a function template specialization uses the
111111
calling convention prescribed by the platform C++ ABI. We know that
112-
[the Itanium ABI maps C++ sigatures to the C
112+
[the Itanium ABI maps C++ signatures to the C
113113
ABI](https://itanium-cxx-abi.github.io/cxx-abi/abi.html#functions) and
114114
therefore will be compatible with the calling convention expected by the
115115
generated `..._rs_api.rs`. Further research is needed to investigate the

docs/overview/limits.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -235,7 +235,7 @@ takes the form of implementation-specific attributes which the compiler can read
235235
to inform what warnings to give.
236236

237237
It is possible to lose safety unless FFI correctly propagates the relevant
238-
information to the ohter side. And in Rust, incorrectly marking functions as
238+
information to the other side. And in Rust, incorrectly marking functions as
239239
unsafe can lead to safety fatigue, where most calls are trivially correct, and
240240
the few that aren't have insufficient review.
241241

docs/overview/reference_safety.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ Examples of C++ features that may mutate a value that Rust holds a reference to:
4444
reference to.
4545
* Mutating public fields of a C++ struct that Rust has a reference to.
4646

47-
TODO: Try to succintly mention the idea that short-lived / non-retained
47+
TODO: Try to succinctly mention the idea that short-lived / non-retained
4848
references are safe from the mutation risk.
4949

5050
## Dangling or null references

docs/overview/unstable_features.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ For each feature we use, we document the following:
3737
### `negative_impls`
3838

3939
* **Crubit feature:** `supported`
40-
* **Use case:** Used to implement `ctor` / nontrivial intialization, so that
40+
* **Use case:** Used to implement `ctor` / nontrivial initialization, so that
4141
we can dispatch on the existence of the `SelfCtor` trait. Also used so that
4242
we can pin/unpin a type without adding a field (which is not possible with
4343
`PhantomPinned`).

0 commit comments

Comments
 (0)