Skip to content

Commit 07b9053

Browse files
committed
Revert changes to getOverrideWhere
1 parent dbb6df1 commit 07b9053

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/snowflake/SnowflakeLogsConnector.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,8 @@ private String createExtendedQueryFromAccountUsage(ConnectorArguments arguments)
290290
String overrideQuery = getOverrideQuery(arguments);
291291
if (overrideQuery != null) return overrideQuery;
292292

293+
String overrideWhere = getOverrideWhere(arguments);
294+
293295
@SuppressWarnings("OrphanedFormatString")
294296
StringBuilder queryBuilder =
295297
new StringBuilder(
@@ -341,7 +343,12 @@ private String createExtendedQueryFromAccountUsage(ConnectorArguments arguments)
341343
+ "AND end_time <= to_timestamp_ltz('%s')\n"
342344
+ "AND is_client_generated_statement = FALSE\n");
343345

344-
queryBuilder.append(getOverrideWhere(arguments));
346+
if (!StringUtils.isBlank(arguments.getQueryLogEarliestTimestamp()))
347+
queryBuilder
348+
.append("AND start_time >= ")
349+
.append(arguments.getQueryLogEarliestTimestamp())
350+
.append("\n");
351+
if (overrideWhere != null) queryBuilder.append(" AND ").append(overrideWhere);
345352
return queryBuilder.toString().replace('\n', ' ');
346353
}
347354

@@ -359,16 +366,10 @@ private String getOverrideQuery(@Nonnull ConnectorArguments arguments)
359366
return null;
360367
}
361368

362-
@Nonnull
369+
@CheckForNull
363370
private String getOverrideWhere(@Nonnull ConnectorArguments arguments)
364371
throws MetadataDumperUsageException {
365-
ConnectorProperty property = SnowflakeLogConnectorProperties.OVERRIDE_WHERE;
366-
String overrideWhere = arguments.getDefinition(property);
367-
if (overrideWhere != null) {
368-
return String.format(" AND %s", overrideWhere);
369-
} else {
370-
return "";
371-
}
372+
return arguments.getDefinition(SnowflakeLogConnectorProperties.OVERRIDE_WHERE);
372373
}
373374

374375
@Override

0 commit comments

Comments
 (0)