Wrap `--add-opens=java.base/java.nio=ALL-UNNAMED as a default envir… (#364)

* Wrap ``--add-opens=java.base/java.nio=ALL-UNNAMED` as a default environment variable for the .sh script.

This is required to deal with Snowflake JDBC error https://community.snowflake.com/s/article/JDBC-Driver-Compatibility-Issue-With-JDK-16-and-Later , which recently re-emerged and is likely to re-emerge again.

* Preserve existing _JAVA_OPTIONS arguments

* Apply the env argument to dwh-migration-dumper application instead.

* Really apply the env argument to dwh-migration-dumper application instead.

* Let gradle build 2 versions of startup scripts for each app and add run-time logic to choose which one based on java version.

 The two apps are dwh-migration-dumper and dwh-cloud-extractor. The versioning logic is applied in dwh-migration-dumper wrapper and in gce_launcher.sh script.

 Maneually tested file generation and executing dwh-migration-dumper with different java versions.
 Tested versions: java8, java11, java17

* Fix Gradle mysterious dependencies

* Fix Gradle mysterious dependencies

* Make the logic more readable.

Author: cyulysses-corp

bin/dwh-migration-dumper

@@ -1,10 +1,12 @@
 #!/bin/sh -ex
 
 BASE_DIR=$(cd "$(dirname "${BASH_SOURCE[0]:-$0}")" 2>&1 > /dev/null && cd .. && pwd)
-BIN="${BASE_DIR}/dumper/app/build/install/app/bin/dwh-migration-dumper"
+. "${BASE_DIR}/dumper/app/src/main/sh/java_versioning.sh"
+BASE_BIN_DIR="${BASE_DIR}/dumper/app/build/install/app/bin"
+BIN=$(is_java_greater_than_8 && echo "${BASE_BIN_DIR}/dwh-migration-dumper" || echo "${BASE_BIN_DIR}/dwh-migration-dumper-java8")
 
 if [ ! -x "$BIN" ] ; then
   (cd "${BASE_DIR}" && ./gradlew --parallel :dumper:app:installDist)
 fi
 
-exec "$BIN" "$@"
+exec "$BIN" "$@"

dumper/app/build.gradle

@@ -94,6 +94,20 @@ dependencies {
 
 startScripts {
     classpath = files('$APP_HOME/lib/*')
+    defaultJvmOpts = ["--add-opens=java.base/java.nio=ALL-UNNAMED"]
+}
+
+task createStartScriptForJava8(type: CreateStartScripts) {
+    mainClass = tasks.startScripts.mainClass
+    applicationName = 'dwh-migration-dumper-java8'
+    outputDir = tasks.startScripts.outputDir
+    classpath = tasks.startScripts.classpath
+}
+
+tasks.named('installDist') {
+    dependsOn 'createStartScriptForJava8'
+    dependsOn 'cloudExtractorStartScripts'
+    dependsOn 'cloudExtractorStartScriptsForJava8'
 }
 
 application {
@@ -102,13 +116,22 @@ application {
     applicationName = 'dwh-migration-dumper'
 }
 
-task cloudExtractorStartScripts(type: CreateStartScripts) {
+task cloudExtractorStartScriptsForJava8(type: CreateStartScripts) {
     outputDir = layout.buildDirectory.dir('install/cloud-extractor/bin').get().asFile
     classpath = tasks.startScripts.classpath
     mainClass = 'com.google.edwmigration.dumper.application.dumper.clouddumper.Main'
     applicationName = 'dwh-cloud-extractor'
 }
 
+task cloudExtractorStartScripts(type: CreateStartScripts) {
+    outputDir = tasks.cloudExtractorStartScriptsForJava8.outputDir
+    classpath = tasks.cloudExtractorStartScriptsForJava8.classpath
+    mainClass = tasks.cloudExtractorStartScriptsForJava8.mainClass
+    applicationName = 'dwh-cloud-extractor-java8'
+    defaultJvmOpts = ["--add-opens=java.base/java.nio=ALL-UNNAMED"]
+    dependsOn 'cloudExtractorStartScriptsForJava8'
+}
+
 licenseReport {
     // onlyIf { ! gradle.startParameter.offline }
     filters = [
@@ -551,6 +574,14 @@ tasks.named('check') {
     dependsOn 'checkLicense'
 }
 
+tasks.named('distTar') {
+    dependsOn 'installDist'
+}
+
+tasks.named('distZip') {
+    dependsOn 'installDist'
+}
+
 tasks.register('generateSourceMirror', Copy) {
     from {
         dependencies.createArtifactResolutionQuery()

dumper/app/src/main/sh/cloud_extractor/gce_launcher.sh

@@ -110,7 +110,10 @@ main() {
     die "ZIP file did not contain dwh-migration-tools."
   fi
 
+  . "${dwh_home}/dumper/app/src/main/sh/java_versioning.sh"
   dwh_cloud_extractor="${dwh_home}/bin/dwh-cloud-extractor"
+  dwh_cloud_extractor=$(is_java_greater_than_8 && echo "${dwh_home}/bin/dwh-cloud-extractor" || echo "${dwh_home}/bin/dwh-cloud-extractor-java8")
+
   if [[ ! -x "${dwh_cloud_extractor}" ]]; then
     die "Could not find cloud extractor bin. Got no executable '${dwh_cloud_extractor}'."
   fi

dumper/app/src/main/sh/java_versioning.sh

@@ -0,0 +1,16 @@
+#!/bin/bash
+
+function is_java_greater_than_8() {
+  java_path=$(which java)
+  java_version_output=$($java_path -version 2>&1)
+
+  # Will return 1 for all versions before Java 9, but we do not care.
+  java_major_version=$(echo "$java_version_output" | grep -Eoi 'version "?([0-9]+)' | head -1 | cut -d'"' -f2 | cut -d'.' -f1)
+
+  # Check if the major version is greater than 8.
+  if [[ $java_major_version -gt 8 ]]; then
+    return 0  # True
+  else
+    return 1  # False
+  fi
+}