[Snowflake Connector] Include more column properties in the metadata archive. (#827)

Author: paolomorandini

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/snowflake/SnowflakeMetadataConnector.java

@@ -211,7 +211,8 @@ public final void addTasksTo(
         getOverrideableQuery(
             arguments,
             "SELECT table_catalog, table_schema, table_name, ordinal_position, column_name,"
-                + " data_type FROM %1$s.COLUMNS%2$s",
+                + " data_type, is_nullable, column_default, character_maximum_length,"
+                + " numeric_precision, numeric_scale, datetime_precision, comment FROM %1$s.COLUMNS%2$s",
             MetadataView.COLUMNS),
         ColumnsFormat.IS_ZIP_ENTRY_NAME,
         IS,

dumper/app/src/test/java/com/google/edwmigration/dumper/application/dumper/connector/snowflake/SnowflakeMetadataConnectorTest.java

@@ -36,7 +36,6 @@
 import javax.annotation.Nonnull;
 import org.junit.Assert;
 import org.junit.Assume;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.junit.runners.JUnit4;
@@ -138,7 +137,6 @@ public void testDatabaseNameFailure() {
     Assert.assertTrue(exception.getMessage().startsWith("Database name not found"));
   }
 
-  @Ignore
   @Test
   public void connector_generatesExpectedSql() throws IOException {
     Map<String, String> actualSqls = collectSqlStatements();

dumper/app/src/test/resources/connector/snowflake/jdbc-tasks-sql.yaml

@@ -4,10 +4,10 @@ schemata-au.csv: "SELECT catalog_name, schema_name FROM SNOWFLAKE.ACCOUNT_USAGE.
 schemata.csv: "SELECT catalog_name, schema_name FROM INFORMATION_SCHEMA.SCHEMATA"
 tables-au.csv: "SELECT table_catalog, table_schema, table_name, table_type, row_count, bytes, clustering_key FROM SNOWFLAKE.ACCOUNT_USAGE.TABLES WHERE DELETED IS NULL"
 tables.csv: "SELECT table_catalog, table_schema, table_name, table_type, row_count, bytes, clustering_key FROM INFORMATION_SCHEMA.TABLES"
-external_tables.csv: "SELECT table_catalog, table_schema, table_name, location, file_format_name, file_format_type FROM INFORMATION_SCHEMA.EXTERNAL_TABLES WHERE table_schema != 'INFORMATION_SCHEMA'"
-columns-au.csv: "SELECT table_catalog, table_schema, table_name, ordinal_position, column_name, data_type FROM SNOWFLAKE.ACCOUNT_USAGE.COLUMNS WHERE DELETED IS NULL"
-columns.csv: "SELECT table_catalog, table_schema, table_name, ordinal_position, column_name, data_type FROM INFORMATION_SCHEMA.COLUMNS"
+columns-au.csv: "SELECT table_catalog, table_schema, table_name, ordinal_position, column_name, data_type, is_nullable, column_default, character_maximum_length, numeric_precision, numeric_scale, datetime_precision, comment FROM SNOWFLAKE.ACCOUNT_USAGE.COLUMNS WHERE DELETED IS NULL"
+columns.csv: "SELECT table_catalog, table_schema, table_name, ordinal_position, column_name, data_type, is_nullable, column_default, character_maximum_length, numeric_precision, numeric_scale, datetime_precision, comment FROM INFORMATION_SCHEMA.COLUMNS"
 views-au.csv: "SELECT table_catalog, table_schema, table_name, view_definition FROM SNOWFLAKE.ACCOUNT_USAGE.VIEWS WHERE DELETED IS NULL"
 views.csv: "SELECT table_catalog, table_schema, table_name, view_definition FROM INFORMATION_SCHEMA.VIEWS"
 functions-au.csv: "SELECT function_schema, function_name, data_type, argument_signature FROM SNOWFLAKE.ACCOUNT_USAGE.FUNCTIONS WHERE DELETED IS NULL"
 functions.csv: "SELECT function_schema, function_name, data_type, argument_signature FROM INFORMATION_SCHEMA.FUNCTIONS"
+external_tables.csv: "SHOW EXTERNAL TABLES"

dumper/lib-dumper-spi/src/main/java/com/google/edwmigration/dumper/plugin/lib/dumper/spi/SnowflakeMetadataDumpFormat.java

@@ -70,7 +70,14 @@ enum Header {
       TableName,
       OrdinalPosition,
       ColumnName,
-      DataType
+      DataType,
+      IsNullable,
+      ColumnDefault,
+      CharacterMaximumLength,
+      NumericPrecision,
+      NumericScale,
+      DatetimePrecision,
+      Comment
     }
   }