Skip to content

Commit 3229f47

Browse files
committed
Add annotations
1 parent 44175b7 commit 3229f47

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/Connector.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
import java.time.ZonedDateTime;
2525
import java.util.List;
2626
import javax.annotation.Nonnull;
27+
import javax.annotation.OverridingMethodsMustInvokeSuper;
2728

2829
/** @author shevek */
2930
public interface Connector {
@@ -50,7 +51,8 @@ default String getDescription() {
5051
* @param arguments cli params
5152
* @throws RuntimeException if incorrect set of arguments passed to the particular connector
5253
*/
53-
default void validate(ConnectorArguments arguments) {}
54+
@OverridingMethodsMustInvokeSuper
55+
default void validate(@Nonnull ConnectorArguments arguments) {}
5456

5557
default void validateDateRange(ConnectorArguments arguments) {
5658
ZonedDateTime startDate = arguments.getStartDate();

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/airflow/AirflowConnector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -209,7 +209,7 @@ private static void addQueryTask(
209209
}
210210

211211
@Override
212-
public void validate(ConnectorArguments arguments) {
212+
public void validate(@Nonnull ConnectorArguments arguments) {
213213
Preconditions.checkState(arguments.isAssessment(), "--assessment flag is required");
214214
Preconditions.checkState(
215215
arguments.getDriverPaths() != null && !arguments.getDriverPaths().isEmpty(),

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/cloudera/manager/ClouderaManagerConnector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ public ClouderaManagerHandle open(@Nonnull ConnectorArguments arguments) throws
129129
}
130130

131131
@Override
132-
public void validate(ConnectorArguments arguments) {
132+
public void validate(@Nonnull ConnectorArguments arguments) {
133133
String clouderaUri = arguments.getUri();
134134
Preconditions.checkNotNull(clouderaUri, "--url for Cloudera Manager API is required");
135135

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/hadoop/oozie/OozieConnector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public String getDefaultFileName(boolean isAssessment, Clock clock) {
7979
}
8080

8181
@Override
82-
public void validate(ConnectorArguments arguments) {
82+
public void validate(@Nonnull ConnectorArguments arguments) {
8383
Preconditions.checkState(arguments.isAssessment(), "--assessment flag is required");
8484

8585
validateDateRange(arguments);

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/snowflake/SnowflakeLogsConnector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ private TaskDescription(
161161
}
162162

163163
@Override
164-
public final void validate(ConnectorArguments arguments) {
164+
public final void validate(@Nonnull ConnectorArguments arguments) {
165165
super.validate(arguments);
166166

167167
if (arguments.isAssessment() && arguments.hasQueryLogEarliestTimestamp()) {

0 commit comments

Comments
 (0)