Skip to content

Commit 5b39bbb

Browse files
authored
Revert changes to getOverrideWhere (#946)
1 parent dbb6df1 commit 5b39bbb

File tree

1 file changed

+11
-13
lines changed

1 file changed

+11
-13
lines changed

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/snowflake/SnowflakeLogsConnector.java

Lines changed: 11 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,8 @@ private String createExtendedQueryFromAccountUsage(ConnectorArguments arguments)
290290
String overrideQuery = getOverrideQuery(arguments);
291291
if (overrideQuery != null) return overrideQuery;
292292

293+
String overrideWhere = getOverrideWhere(arguments);
294+
293295
@SuppressWarnings("OrphanedFormatString")
294296
StringBuilder queryBuilder =
295297
new StringBuilder(
@@ -341,7 +343,12 @@ private String createExtendedQueryFromAccountUsage(ConnectorArguments arguments)
341343
+ "AND end_time <= to_timestamp_ltz('%s')\n"
342344
+ "AND is_client_generated_statement = FALSE\n");
343345

344-
queryBuilder.append(getOverrideWhere(arguments));
346+
if (!StringUtils.isBlank(arguments.getQueryLogEarliestTimestamp()))
347+
queryBuilder
348+
.append("AND start_time >= ")
349+
.append(arguments.getQueryLogEarliestTimestamp())
350+
.append("\n");
351+
if (overrideWhere != null) queryBuilder.append(" AND ").append(overrideWhere);
345352
return queryBuilder.toString().replace('\n', ' ');
346353
}
347354

@@ -359,25 +366,16 @@ private String getOverrideQuery(@Nonnull ConnectorArguments arguments)
359366
return null;
360367
}
361368

362-
@Nonnull
369+
@CheckForNull
363370
private String getOverrideWhere(@Nonnull ConnectorArguments arguments)
364371
throws MetadataDumperUsageException {
365-
ConnectorProperty property = SnowflakeLogConnectorProperties.OVERRIDE_WHERE;
366-
String overrideWhere = arguments.getDefinition(property);
367-
if (overrideWhere != null) {
368-
return String.format(" AND %s", overrideWhere);
369-
} else {
370-
return "";
371-
}
372+
return arguments.getDefinition(SnowflakeLogConnectorProperties.OVERRIDE_WHERE);
372373
}
373374

374375
@Override
375376
public final void addTasksTo(
376377
@Nonnull List<? super Task<?>> out, @Nonnull ConnectorArguments arguments)
377378
throws MetadataDumperUsageException {
378-
379-
boolean isAssessment = arguments.isAssessment();
380-
381379
out.add(new DumpMetadataTask(arguments, FORMAT_NAME));
382380
out.add(new FormatTask(FORMAT_NAME));
383381

@@ -392,7 +390,7 @@ public final void addTasksTo(
392390
arguments, rotationDuration, IntervalExpander.createBasedOnDuration(rotationDuration));
393391
logger.info("Exporting query log for " + queryLogIntervals);
394392

395-
if (!isAssessment) {
393+
if (!arguments.isAssessment()) {
396394
TaskDescription queryHistoryTask =
397395
new TaskDescription(ZIP_ENTRY_PREFIX, newQueryFormat(arguments), Header.class);
398396
queryLogIntervals.forEach(interval -> addJdbcTask(out, interval, queryHistoryTask));

0 commit comments

Comments
 (0)