Test an exception message

Author: misolt

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/snowflake/AbstractSnowflakeConnector.java

@@ -42,9 +42,9 @@
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Properties;
+import java.util.function.Supplier;
 import javax.annotation.Nonnull;
 import javax.sql.DataSource;
-import org.apache.commons.lang3.StringUtils;
 import org.springframework.jdbc.core.JdbcTemplate;
 import org.springframework.jdbc.datasource.SimpleDriverDataSource;
 
@@ -196,16 +196,23 @@ private void setCurrentDatabase(@Nonnull String databaseName, @Nonnull JdbcTempl
     String currentDatabase =
         jdbcTemplate.queryForObject(String.format("USE DATABASE %s;", databaseName), String.class);
     if (currentDatabase == null) {
-      List<String> dbNames =
-          jdbcTemplate.query("SHOW DATABASES", (rs, rowNum) -> rs.getString("name"));
-      throw new MetadataDumperUsageException(
-          "Database name not found "
-              + databaseName
-              + ", use one of: "
-              + StringUtils.join(dbNames, ", "));
+      Supplier<List<String>> showQuery =
+          () -> jdbcTemplate.query("SHOW DATABASES", (rs, rowNum) -> rs.getString("name"));
+      throw unrecognizedDatabase(databaseName, showQuery);
     }
   }
 
+  @Nonnull
+  static MetadataDumperUsageException unrecognizedDatabase(
+      @Nonnull String database, @Nonnull Supplier<List<String>> availableDatabases) {
+    List<String> names = availableDatabases.get();
+    String joinedNames = String.join(", ", names);
+    String message =
+        String.format("Database name not found %s, use one of: %s", database, joinedNames);
+
+    return new MetadataDumperUsageException(message);
+  }
+
   String sanitizeDatabaseName(@Nonnull String databaseName) throws MetadataDumperUsageException {
     int lengthWithQuotes = databaseName.length() + 2;
     int maxLength = 255;

dumper/app/src/test/java/com/google/edwmigration/dumper/application/dumper/connector/snowflake/AbstractSnowflakeConnectorTest.java

@@ -16,7 +16,9 @@
  */
 package com.google.edwmigration.dumper.application.dumper.connector.snowflake;
 
+import static com.google.edwmigration.dumper.application.dumper.connector.snowflake.AbstractSnowflakeConnector.unrecognizedDatabase;
 import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertThrows;
 import static org.junit.Assert.assertTrue;
 
@@ -26,6 +28,8 @@
 import com.google.edwmigration.dumper.application.dumper.connector.AbstractConnectorTest;
 import java.io.IOException;
 import java.util.ArrayList;
+import java.util.List;
+import java.util.function.Supplier;
 import org.junit.Assert;
 import org.junit.Test;
 import org.junit.experimental.theories.Theories;
@@ -127,6 +131,18 @@ public void validate_mixedPrivateKeyAndPassword_fail() throws IOException {
                 "Private key authentication method can't be used together with user password"));
   }
 
+  @Test
+  public void unrecognizedDatabase_success() {
+    Supplier<List<String>> databases = () -> ImmutableList.of("SNOWFLAKE", "FIRSTDB", "SECONDDB");
+
+    String message = unrecognizedDatabase("WRONGNAMEDB", databases).getMessage();
+
+    assertNotNull(message);
+    assertTrue(message, message.contains("WRONGNAMEDB"));
+    assertTrue(message, message.contains("Database name not found"));
+    assertTrue(message, message.contains("SNOWFLAKE, FIRSTDB, SECONDDB"));
+  }
+
   enum TestEnum {
     SomeValue
   }