Skip to content

Commit ed75f92

Browse files
authored
Apply timestamp prefix to querylogs only (#137)
* Apply timestamp prefix to querylogs only.
1 parent 7b890de commit ed75f92

File tree

4 files changed

+17
-24
lines changed

4 files changed

+17
-24
lines changed

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/Connector.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,8 @@
1919
import com.google.edwmigration.dumper.application.dumper.ConnectorArguments;
2020
import com.google.edwmigration.dumper.application.dumper.handle.Handle;
2121
import com.google.edwmigration.dumper.application.dumper.task.Task;
22-
import java.text.Format;
23-
import java.text.SimpleDateFormat;
2422
import java.util.List;
2523
import javax.annotation.Nonnull;
26-
import org.apache.commons.lang3.StringUtils;
2724

2825
/**
2926
*
@@ -39,16 +36,7 @@ public enum DefaultProperties implements ConnectorProperty {
3936
public String getName();
4037

4138
@Nonnull
42-
default String getDefaultFileName(boolean isAssessment) {
43-
Format format = new SimpleDateFormat("yyyyMMdd'T'HHmmss");
44-
String timeSuffix = "-" + format.format(System.currentTimeMillis());
45-
return String.format("dwh-migration-%s-%s%s.zip",
46-
getName(), getType(), isAssessment ? timeSuffix : StringUtils.EMPTY
47-
);
48-
}
49-
50-
@Nonnull
51-
String getType();
39+
public String getDefaultFileName(boolean isAssessment);
5240

5341
@Nonnull
5442
public void addTasksTo(@Nonnull List<? super Task<?>> out,

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/LogsConnector.java

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,23 @@
1616
*/
1717
package com.google.edwmigration.dumper.application.dumper.connector;
1818

19+
import java.text.Format;
20+
import java.text.SimpleDateFormat;
21+
import javax.annotation.Nonnull;
22+
import org.apache.commons.lang3.StringUtils;
23+
1924
/**
2025
*
2126
* @author shevek
2227
*/
2328
public interface LogsConnector extends Connector {
24-
@Override
25-
default String getType() {
26-
return "logs";
29+
30+
@Nonnull
31+
default String getDefaultFileName(boolean isAssessment) {
32+
Format format = new SimpleDateFormat("yyyyMMdd'T'HHmmss");
33+
String timeSuffix = "-" + format.format(System.currentTimeMillis());
34+
return String.format("dwh-migration-%s-logs%s.zip",
35+
getName(), isAssessment ? timeSuffix : StringUtils.EMPTY);
2736
}
37+
2838
}

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/connector/MetadataConnector.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,9 @@
2121
* @author shevek
2222
*/
2323
public interface MetadataConnector extends Connector {
24+
2425
@Override
25-
default String getType() {
26-
return "metadata";
26+
default String getDefaultFileName(boolean isAssessment) {
27+
return "dwh-migration-" + getName() + "-metadata.zip";
2728
}
2829
}

dumper/app/src/test/java/com/google/edwmigration/dumper/application/dumper/DriverClasspathTest.java

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -132,12 +132,6 @@ public String getDefaultFileName(boolean ignored) {
132132
return StringUtils.EMPTY;
133133
}
134134

135-
@Nonnull
136-
@Override
137-
public String getType() {
138-
return StringUtils.EMPTY;
139-
}
140-
141135
@Override
142136
public void addTasksTo(@Nonnull List<? super Task<?>> out,
143137
@Nonnull ConnectorArguments arguments) {

0 commit comments

Comments
 (0)