Rename diagnostics parameter to telemetry for better clarity

Author: kaxuna

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/ConnectorArguments.java

@@ -82,7 +82,7 @@ public class ConnectorArguments extends DefaultArguments {
           + "\n";
 
   public static final String OPT_CONNECTOR = "connector";
-  public static final String OPT_DIAGNOSTICS = "diagnostics";
+  public static final String OPT_TELEMETRY = "telemetry";
   public static final String OPT_DRIVER = "driver";
   public static final String OPT_CLASS = "jdbcDriverClass";
   public static final String OPT_URI = "url";
@@ -472,9 +472,9 @@ public class ConnectorArguments extends DefaultArguments {
           .ofType(Integer.class)
           .defaultsTo(OPT_THREAD_POOL_SIZE_DEFAULT);
 
-  private final OptionSpec<Boolean> optionDiagnostics =
+  private final OptionSpec<Boolean> optionTelemetry =
       parser
-          .accepts(OPT_DIAGNOSTICS, "Allows dumper diagnostics to be turned on/off")
+          .accepts(OPT_TELEMETRY, "Allows dumper telemetry to be turned on/off")
           .withOptionalArg()
           .ofType(Boolean.class)
           .defaultsTo(true);
@@ -1056,8 +1056,8 @@ public List<String> getQueryLogAlternates() {
     return getOptions().valuesOf(optionQueryLogAlternates);
   }
 
-  public boolean isDiagnosticsOn() {
-    return getOptions().valueOf(optionDiagnostics);
+  public boolean isTelemetryOn() {
+    return getOptions().valueOf(optionTelemetry);
   }
 
   public boolean isTestFlag(char c) {
@@ -1227,7 +1227,7 @@ public String toString() {
             .add(OPT_QUERY_LOG_END, getQueryLogEnd())
             .add(OPT_QUERY_LOG_ALTERNATES, getQueryLogAlternates())
             .add(OPT_ASSESSMENT, isAssessment())
-            .add(OPT_DIAGNOSTICS, isDiagnosticsOn());
+            .add(OPT_TELEMETRY, isTelemetryOn());
     getConnectorProperties().getDefinitionMap().forEach(toStringHelper::add);
     return toStringHelper.toString();
   }

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/MetadataDumper.java

@@ -68,7 +68,7 @@ public MetadataDumper(String... args) throws Exception {
     this.connectorArguments = new ConnectorArguments(JsonResponseFile.addResponseFiles(args));
     telemetryProcessor =
         new TelemetryProcessor(
-            TelemetryStrategyFactory.createStrategy(connectorArguments.isDiagnosticsOn()));
+            TelemetryStrategyFactory.createStrategy(connectorArguments.isTelemetryOn()));
     if (connectorArguments.saveResponseFile()) {
       JsonResponseFile.save(connectorArguments);
     }