Skip to content

Commit ff2e5f5

Browse files
authored
Remove DummyHandle, don't extend AbstractHandle in JdbcHandle (#682)
1 parent 500ce4b commit ff2e5f5

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/handle/JdbcHandle.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
*
3232
* @author shevek
3333
*/
34-
public class JdbcHandle extends AbstractHandle {
34+
public class JdbcHandle implements Handle {
3535

3636
private static final Logger LOG = LoggerFactory.getLogger(JdbcHandle.class);
3737

@@ -71,6 +71,5 @@ public void close() throws IOException {
7171
throw new IOException("Failed to close DataSource: " + e, e);
7272
}
7373
}
74-
super.close();
7574
}
7675
}

dumper/app/src/test/java/com/google/edwmigration/dumper/application/dumper/connector/test/TestConnector.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,14 @@
2222
import com.google.edwmigration.dumper.application.dumper.connector.Connector;
2323
import com.google.edwmigration.dumper.application.dumper.connector.ConnectorProperty;
2424
import com.google.edwmigration.dumper.application.dumper.connector.MetadataConnector;
25-
import com.google.edwmigration.dumper.application.dumper.handle.AbstractHandle;
2625
import com.google.edwmigration.dumper.application.dumper.handle.Handle;
2726
import com.google.edwmigration.dumper.application.dumper.task.Task;
2827
import java.util.List;
2928
import javax.annotation.Nonnull;
3029

3130
@AutoService({Connector.class, MetadataConnector.class})
3231
public class TestConnector extends AbstractConnector implements MetadataConnector {
33-
private static final Handle DUMMY_HANDLE = new AbstractHandle() {};
32+
private static final Handle DUMMY_HANDLE = () -> {};
3433

3534
public TestConnector() {
3635
super("test");

dumper/app/src/test/java/com/google/edwmigration/dumper/application/dumper/task/AbstractTaskTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.google.edwmigration.dumper.application.dumper.task;
1818

1919
import com.google.common.io.ByteSink;
20-
import com.google.edwmigration.dumper.application.dumper.handle.AbstractHandle;
2120
import com.google.edwmigration.dumper.application.dumper.handle.Handle;
2221
import java.io.ByteArrayOutputStream;
2322
import java.io.IOException;
@@ -26,9 +25,7 @@
2625
/** @author shevek */
2726
public abstract class AbstractTaskTest {
2827

29-
protected static class DummyHandle extends AbstractHandle {}
30-
31-
protected static Handle HANDLE = new DummyHandle();
28+
static final Handle HANDLE = () -> {};
3229

3330
public static class MemoryByteSink extends ByteSink {
3431

0 commit comments

Comments
 (0)