Skip to content

Implement Dynamic Tables feature detection #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jakubwrobel00 wants to merge 2 commits into from
Closed

Implement Dynamic Tables feature detection #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8dd9b0
Implement Dynamic Tables feature detection
jakubwrobel00 Dec 5, 2025
bc8dff0
Spotless applied
jakubwrobel00 Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions ...dwmigration/dumper/application/dumper/connector/snowflake/SnowflakeMetadataConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,18 @@ public final void addTasksTo(
isAssessment,
getInformationSchemaWhereCondition("function_catalog", arguments.getDatabases()));

String featuresQuery =
"SELECT 'STORAGE', 'DYNAMIC_TABLES', COUNT(*), 'TABLES' FROM"
+ " SNOWFLAKE.ACCOUNT_USAGE.TABLES WHERE IS_DYNAMIC = 'YES'";

out.add(
new JdbcSelectTask(
FeaturesFormat.IS_ZIP_ENTRY_NAME,
featuresQuery,
TaskCategory.OPTIONAL, // TODO: Change to REQUIRED after implementation is finished
TaskOptions.DEFAULT)
.withHeaderClass(FeaturesFormat.Header.class));

if (isAssessment) {
for (AssessmentQuery item : planner.generateAssessmentQueries()) {
String query = queryForAssessment(item, arguments);
Expand Down
1 change: 1 addition & 0 deletions dumper/app/src/test/resources/connector/snowflake/jdbc-tasks-sql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,4 @@ views.csv: "SELECT table_catalog, table_schema, table_name, view_definition FROM
functions-au.csv: "SELECT function_schema, function_name, data_type, argument_signature FROM SNOWFLAKE.ACCOUNT_USAGE.FUNCTIONS WHERE DELETED IS NULL"
functions.csv: "SELECT function_schema, function_name, data_type, argument_signature FROM INFORMATION_SCHEMA.FUNCTIONS"
external_tables.csv: "SHOW EXTERNAL TABLES"
features.csv: "SELECT 'STORAGE', 'DYNAMIC_TABLES', COUNT(*), 'TABLES' FROM SNOWFLAKE.ACCOUNT_USAGE.TABLES WHERE IS_DYNAMIC = 'YES'"
12 changes: 12 additions & 0 deletions ...ava/com/google/edwmigration/dumper/plugin/lib/dumper/spi/SnowflakeMetadataDumpFormat.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,4 +169,16 @@ enum Header {
OwnerRoleType
}
}

interface FeaturesFormat {

String IS_ZIP_ENTRY_NAME = "features.csv";

enum Header {
FeatureType,
FeatureName,
Count,
Description
}
}
}