feat: Add individual task telemetry to dumper system #949

kaxuna · 2025-08-27T21:03:43Z

Create TaskRunMetrics class for individual task timing and error tracking
Enhance TasksRunner to capture start/end times and errors for each task
Update MetadataDumper to pass telemetry processor to TasksRunner

- Create TaskRunMetrics class for individual task timing and error tracking - Enhance TasksRunner to capture start/end times and errors for each task - Add addTaskTelemetry method to TelemetryProcessor - Update MetadataDumper to pass telemetry processor to TasksRunner - Add comprehensive tests for new telemetry functionality - Maintain backward compatibility with existing telemetry system This enhancement provides granular visibility into individual task execution performance and error details, complementing the existing overall runtime metrics.

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/TasksRunner.java

vladislav-sidorovich · 2025-08-28T08:47:50Z

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/TasksRunner.java

+
+  private void addTaskTelemetry(
+      String taskName, Instant startTime, Instant endTime, TaskState state) {
+    if (telemetryProcessor != null) {


Let's add Precondition to constructor and remove this if.

dumper/app/src/main/java/com/google/edwmigration/dumper/application/dumper/TasksRunner.java

vladislav-sidorovich · 2025-08-28T08:51:23Z

.../src/main/java/com/google/edwmigration/dumper/application/dumper/metrics/TaskRunMetrics.java

+ */
+public class TaskRunMetrics implements TelemetryPayload {
+
+  @JsonProperty private String name;


I thinks we need both, taskName and taskClass. Another option is to redesign somehow our hierarchy of connectors and tasks.

vladislav-sidorovich · 2025-08-28T08:54:40Z

.../src/main/java/com/google/edwmigration/dumper/application/dumper/metrics/TaskRunMetrics.java

+
+  @JsonProperty private String name;
+
+  @JsonProperty private EventType eventType = EventType.TASK_RUN_METRICS;


It should be on level above, before payload.
The logic on the service to parse event should be something like this:

EventType type = event.getType(); if (type is A) { //payload is audi, do audi specific } else if (type is B) { //payload is bwm, do bwm specific }

.../src/main/java/com/google/edwmigration/dumper/application/dumper/metrics/TaskRunMetrics.java

kaxuna requested review from shevek-google and vladislav-sidorovich as code owners August 27, 2025 21:03

kaxuna added 3 commits August 27, 2025 23:07

added taskType

8316a20

fix: Add trailing comma to EventType enum for better compatibility

5136f05

removed unneccesery test

541f5cb